[buddypress-trac] [BuddyPress Trac] #5775: Registration: email, password strength, username JS validation

[buddypress-trac]

#5775: Registration: email, password strength, username JS validation
---------------------------+-----------------------------
 Reporter:  SGr33n         |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  Future Release
Component:  Core           |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  needs-refresh  |
---------------------------+-----------------------------
Changes (by boonebgorges):

 * keywords:  has-patch => needs-refresh


Comment:

 Basic approach seems OK to me. Loading a separate 'register.js' is OK,
 though I wonder if we might do this based on functionality (password-
 verify.js) rather than based on the current page (register.js). This would
 mirror WP's organization better, and would make it more modular for use
 on, eg, the settings page.

 I'm not sure I see the need for a separate `enqueue_bp_pages_scripts()`
 method. I think this logic can go into the `enqueue_scripts()` method. In
 that method, you should be able to use `bp_is_register_page()` rather than
 checking the settings directly.

 JS could use some formatting cleanup. And I'd say that the
 checkPassStrength() function can probably go inside the `function( $ )`
 scope, since it requires jQuery. As an aside: I haven't looked, but does
 WP not have a standalone function that we could use for this purpose?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5775#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac