[buddypress-trac] [BuddyPress Trac] #5731: text/number profile fields not rendered if value == 0

buddypress-trac noreply at wordpress.org
Wed Jul 23 14:37:13 UTC 2014

#5731: text/number profile fields not rendered if value == 0
 Reporter:  DJPaul        |       Owner:  djpaul
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  2.1
Component:  XProfile      |     Version:  1.0
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |

Comment (by boonebgorges):

 WCUADD - Thanks for the clarifications. Your patch is definitely in
 keeping with what's in r8554. What I'm suggesting is that the route taken
 in r8554 is somewhat crazy :)

 I like your "three level of checks" breakdown, but for our purposes here,
 it's worth noting that each of these should be handled on a field-type
 basis. That is, all of these checks belong in the `BP_XProfile_Field_Type`
 classes, and *not* in the form handlers. So this speaks to the sanity of
 my suggested approach.

 So, long run: the `! empty()` checks should be replaced with `isset()`.
 However, we have a very small amount of time before 2.1, so I think we
 need to decide what to do in the short run. Is it feasible to do all the
 necessary swaps and tests in the next week or so? We would need someone to
 write the patch. If it's *not* feasible, are the current bugs too severe
 to ship in 2.1? (It seems to me that they are relative edge cases, but I'd
 value someone else's thoughts.)

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5731#comment:14>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list