[buddypress-trac] [BuddyPress Trac] #5652: root_blog_id problem since trunk has been "gruntified" for website using trunk version

[buddypress-trac]

#5652: root_blog_id problem since trunk has been "gruntified" for website using
trunk version
--------------------------+-----------------------
 Reporter:  imath         |       Owner:  imath
     Type:  defect (bug)  |      Status:  reopened
 Priority:  high          |   Milestone:  2.1
Component:  Core          |     Version:  2.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by r-a-y):

 > You say "take advantage of newer fixes in WP core" which sounds to me
 like this would cause a bump in the minimum supported WordPress version
 for BuddyPress. I don't mind doing that, but I just wanted to surface that
 here.

 According to our readme.txt, we support down to WP 3.6.  WP 3.6 has the
 fixes in `plugin_dir_url()` and `plugin_dir_path()` that I reference `in
 src/bp-loader.php`.

 > I see you removed the "If we're using https, update the protocol" bit --
 I can't remember why we added that, but don't we still need that?

 `plugin_dir_url()` uses `plugins_url()`, which should switch to SSL
 automatically.

 > do you have time this next week to get this into trunk?

 I think the patch works, but could use some additional feedback before
 committing.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5652#comment:14>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac