[buddypress-trac] [BuddyPress Trac] #5501: Custom xprofile field: URL
buddypress-trac
noreply at wordpress.org
Thu Jul 17 09:21:01 UTC 2014
#5501: Custom xprofile field: URL
-------------------------------------+------------------
Reporter: sooskriszta | Owner:
Type: enhancement | Status: new
Priority: high | Milestone: 2.1
Component: XProfile | Version:
Severity: normal | Resolution:
Keywords: needs-patch 2nd-opinion |
-------------------------------------+------------------
Comment (by DJPaul):
I would very much like to see r8638 moved out of `xprofile_set_field_data`
and into a field type class/hooked to a field type class, something like
Boone suggests.
It took a lot of effort to remove all the xprofile field type checks that
were hardcoded when I worked on this for 2.0. Plus, parsing a URL without
using `parse_url`, and (for some reason) allowing extensions for `.php`
files only, seems a bit off.
To simplify, I suggest we don't support relative paths in the URL field
type (at the moment?), and require absolute URLs. We can then use
`esc_url_raw()` to both sanitise (if we're not already) and it will add a
`http` prefix onto the URL if one is missing.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5501#comment:30>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list