[buddypress-trac] [BuddyPress Trac] #5740: Description sould be part of the $field_type->edit_field_html() ? / scope of this function

buddypress-trac noreply at wordpress.org
Wed Jul 9 01:39:46 UTC 2014

#5740: Description sould be part of the $field_type->edit_field_html() ? / scope
of this function
 Reporter:  WCUADD       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Future Release
Component:  XProfile     |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |
Changes (by boonebgorges):

 * milestone:  Awaiting Review => Future Release


 I like this idea - I agree that it makes more sense for this markup to be
 within the scope of the `BP_XProfile_Field_Type` class, if not the
 `edit_field_html()` method itself. But this is going to be a very
 difficult thing to implement, because the description and visibility
 markup is currently called directly from the templates. So we'd have to
 remove it from the templates. But then anyone who is overriding the core
 templates will see the fields twice.

 For this reason, I think the suggestion, while a good one, will have to
 wait until we do a rewrite of the xprofile editing templates, and do a
 full break of backward compatibility with bp-legacy. See #4952 for ongoing

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5740#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list