[buddypress-trac] [BuddyPress Trac] #5736: messages_format_notifications(): variables not in scope

[buddypress-trac]

#5736: messages_format_notifications(): variables not in scope
--------------------------+-----------------------------
 Reporter:  wpdennis      |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Messaging     |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 If [https://buddypress.trac.wordpress.org/browser/trunk/src/bp-messages
 /bp-messages-notifications.php#L124 messages_format_notifications()] is
 used with any other action than "new_message", the variables '''$link''',
 '''$filter''' and '''$text''' aren't declared before usage:


 {{{
 if ( 'string' === $format ) {
     $return = apply_filters( $filter, '<a href="' . esc_url( $link ) . '"
 title="' . esc_attr( $title ) . '">' . esc_html( $text ) . '</a>', (int)
 $total_items, $text, $link, $item_id, $secondary_item_id );
 } else {
     $return = apply_filters( $filter, array(
         'text' => $text,
         'link' => $link
     ), $link, (int) $total_items, $text, $link, $item_id,
 $secondary_item_id );
 }
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5736>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac