[buddypress-trac] [BuddyPress Trac] #3278: @mentions autosuggest support

buddypress-trac noreply at wordpress.org
Wed Jul 2 12:40:22 UTC 2014

#3278: @mentions autosuggest support
 Reporter:  DJPaul         |       Owner:
     Type:  enhancement    |      Status:  assigned
 Priority:  normal         |   Milestone:  2.1
Component:  Notifications  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  dev-feedback   |

Comment (by boonebgorges):

 Patch applies cleanly for me.

 Thanks a million for this, DJPaul. In my (humble) opinion, it's much more
 understandable - it's fairly obvious, by looking at a class like
 `BP_Members_Suggestions`, how to build my own suggestion service.

 One small architectural suggestion. It would make implementation a bit
 simpler if `bp_core_get_suggestions()` took a `class` parameter rather
 than requiring `type` and then translating that into a class name. True, a
 few more characters to type in the case of core-provided services; but one
 less thing to do when building one's own service (no need to `add_filter(
 'bp_suggestions_services' )`). The only reason I can see for forcing the
 registration of the service is if we needed to have a list of registered
 services somewhere (say, to build an admin UI that lists all suggestion
 types?), but nothing like that is being proposed here, so I think it's
 unneccesary overhead. And if we ever decided we needed a list of these
 classes, we could in theory do something like
 http://stackoverflow.com/a/16680186. Anyway, not a dealbreaker, just a

 Approach looks great to me otherwise.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3278#comment:28>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list