[buddypress-trac] [BuddyPress Trac] #5197: Access Member Profiles from the Admin Backend

buddypress-trac noreply at wordpress.org
Tue Jan 28 14:39:46 UTC 2014

#5197: Access Member Profiles from the Admin Backend
 Reporter:  svenl77                       |       Owner:
     Type:  enhancement                   |      Status:  new
 Priority:  high                          |   Milestone:  2.0
Component:  Members                       |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  has-patch 2nd-opinion commit  |
Changes (by boonebgorges):

 * keywords:  has-patch 2nd-opinion => has-patch 2nd-opinion commit


 Looking excellent!

 5197.02.diff has a couple minor changes:

 1. I saw your hack for setting $bp->displayed_user->id. As you noted in
 the inline comments, this doesn't seem right. And I'm not sure if it'll
 affect plugins etc that are checking bp_is_user() and
 bp_displayed_user_id(). So, in a separate commit (which you'll see come
 through in a second), I've modified bp_get_the_profile_field_options() to
 accept a user_id param, and then modified the patch to use it. This seems
 much less hackish.

 2. You were using the function `touch_time()` to render a non-js time
 field. This isn't relevant for our purposes, and in fact it's broken due
 to the internals of the function (which require either the $post or
 $comment global), so I removed the block.

 3. Cleaned up inline docs to better match our standard.

 I think it's ready to commit.

 I do have a question: I see that you're filtering
 'bp_get_the_profile_field_options_radio' and '_checkbox'. The only
 difference I could see is that you're adding a `<br />`. Is that right?
 Can't you do this with CSS?

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5197#comment:21>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list