[buddypress-trac] [BuddyPress Trac] #5301: Theme compat: Reset post arguments should not set 'is_archive' to true

buddypress-trac noreply at wordpress.org
Mon Jan 13 17:30:42 UTC 2014

#5301: Theme compat: Reset post arguments should not set 'is_archive' to true
 Reporter:  michaello13   |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  highest       |   Milestone:  1.9.2
Component:  Core          |     Version:  1.7
 Severity:  normal        |  Resolution:
 Keywords:                |

Comment (by johnjamesjacoby):

 Replying to [comment:14 boonebgorges]:
 > See also #5307.
 > I can't think of any negative side effects of this, but it would be nice
 for jjj to chime in on the switch to is_page (and the original
 justification for is_archive).
 My original thought was to have the arguments better match WordPress's
 paradigm, to have `is_archive` set for our directories, and `is_single`
 set for single groups, members, etc... Ironically, that never happened,
 and they're all set to `is_archive`, likely from copy/pasting, and in
 testing, it still worked in themes that behaved correctly.

 Thinking back, this is probably a case of good intentions gone bad. Since
 so much in WordPress relies on the main query and its parameters
 (including the way we calculate theme compatibility) it does seem proper
 to set `is_page` to true in all cases, and introduce our own extra
 arguments as they are needed (for things like rewrite rules.)

 I'm okay with this fix, and I'll do the same for bbPress in the next few

 Nice work tracking this down.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5301#comment:15>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list