[buddypress-trac] [BuddyPress Trac] #5301: Theme compat: Reset post arguments should not set 'is_archive' to true (was: New buddypress 1.9 bug)

buddypress-trac noreply at wordpress.org
Mon Jan 13 03:01:40 UTC 2014

#5301: Theme compat: Reset post arguments should not set 'is_archive' to true
 Reporter:  michaello13   |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  highest       |   Milestone:  1.9.2
Component:  Core          |     Version:  1.7
 Severity:  normal        |  Resolution:
 Keywords:                |
Changes (by r-a-y):

 * status:  closed => reopened
 * priority:  normal => highest
 * version:  1.9 => 1.7
 * milestone:   => 1.9.2
 * resolution:  wontfix =>


 Reopening ticket.

 This problem never came up in the past because we were echoing the_content
 code immediately (see #5156, which fixed this behavior).

 It turns out that BP is the problem.

 The themes that have some type of template loader logic are all checking
 against what type of post the current page is.

 When BP runs its theme-compat code, BP resets the post so `'is_archive'`
 set to true.  For themes with template loader logic, they will load up
 their archive template and the archive template historically uses
 `the_excerpt()` causing all formatting to be stripped out.

 I've attached a simple patch against 1.9-branch that switches out all of
 our reset post code so `'is_page'` is set to true and removes the
 `'is_archive'` portion.

 Test this with the Attitude theme, [http://buddypress.org/support/topic
 from-1-8-to-1-9/#post-176795 which a user mentioned on the BP forums]
 (props to him):

 This should fix all the other themes like Thesis as well, but let's get
 some people testing the patch immediately.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5301#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list