[buddypress-trac] [BuddyPress Trac] #5374: Administation screen to manage signups

[buddypress-trac]

#5374: Administation screen to manage signups
-------------------------------------------------+------------------
 Reporter:  imath                                |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  high                                 |   Milestone:  2.0
Component:  Members                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  2nd-opinion has-patch needs-testing  |
-------------------------------------------------+------------------

Comment (by imath):

 Replying to [comment:12 boonebgorges]:
 > I've had a chance to review this patch in some detail. Very nice work -
 I think it's going to be a huge improvement.

 Thanks a lot boonebgorges & for all this great improvements :)

 I've tested it on multisite with BuddyPress not network activated and on a
 non multisite config. I've found 3 details, explaining 5374.06.patch :)

 1- Bulk Actions are "$_POSTed" instead of "$_GETed", so i've modified
 2- Concerning signups username check when the constant
 BP_SIGNUPS_SKIP_USER_CREATION is set to true, a letter was missing in a
 var. so it wasn't checking
 3- in the resend method, the old meta was lost as soon as a mail was sent,
 so i've added a line ;)

 Other than this little details, i confirm it's working great !!

 > It's confusing to have the Mail link simply disappear when within 24
 hours of the last resend. Maybe we could change the color or have some
 hover-text or disable it *or something*.
 i understand, i think that we could simply print the text with no link
 instead of not showing it at all.

 Finally, i agree, it would be great to have some tests on various configs
 to see if every case is covered. I think after the commit, it can also be
 interesting to write a note on bpdevel to inform of the changes about the
 way signups will be managed. And maybe progessively stop creating users to
 'BP_SIGNUPS_SKIP_USER_CREATION' by default ;)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5374#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac