[buddypress-trac] [BuddyPress Trac] #5419: Object cache active notice

buddypress-trac noreply at wordpress.org
Sun Feb 23 01:21:25 UTC 2014

#5419: Object cache active notice
 Reporter:  r-a-y        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.0
Component:  Messaging    |     Version:  1.0
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |

Comment (by boonebgorges):

 Unit test looks fine to me. Theoretically you could split it into two
 tests, but it's fine to put them together. (Only practical difference is
 that when you do multiple assertions in a single test, and one fails, the
 rest of the assertions in that test are not run. So if you're going to put
 them together, make sure they're closely linked and would likely be broken
 by the same bug.)

 I'm pretty sure `do_action_ref_array()` is not necessary here. `do_action(
 'messages_notice_before_delete', $this )` will pass the object by
 reference automatically, as of PHP 5.0.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5419#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list