[buddypress-trac] [BuddyPress Trac] #5272: Use $args parameter on BP_Blogs instead of 8 variables

buddypress-trac noreply at wordpress.org
Fri Feb 7 13:40:04 UTC 2014

#5272: Use $args parameter on BP_Blogs instead of 8 variables
 Reporter:  lenasterg      |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  2.0
Component:  Blogs          |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  needs-refresh  |
Changes (by boonebgorges):

 * keywords:   => needs-refresh
 * milestone:  Future Release => 2.0


 Hi lenasterg,

 The changes look good at a glance, but it'll be really difficult to apply
 in this format. Can I ask you to fix some things? A couple tips:

 - The most important thing is to find the setting in your text editor/IDE
 that is changing whitespace from tabs into spaces and *turn it off*. It's
 rewriting every single line in the file, which is making it difficult to
 apply your much more limited changes. If you could do this alone, it would
 make our lives much easier :)
 - It's best practice to keep fixes separate (such as the DISTINCT fixes
 you mention). It's easy for me to separate them out of your patch from a
 technical point of view, but it keeps discussion more focused if they're
 on their own tickets.
 - Ideally, you'd generate a proper patch. In brief,
     - make sure you're working from an SVN checkout
     - Please work from trunk rather than 1.9.2
     - then generate a patch file using the `svn diff` command.

 Here are a couple helpful pages for getting set up with SVN (Subversion):
 They are specific to WordPress, but the process is the same with

 Thanks so much for your contribution! With a refresh, we can get this in
 for 2.0.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5272#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list