[buddypress-trac] [BuddyPress Trac] #6008: Remove HTML from post_title for groups

buddypress-trac noreply at wordpress.org
Sat Dec 13 13:11:05 UTC 2014

#6008: Remove HTML from post_title for groups
 Reporter:  alexander.rohmann  |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  high               |   Milestone:  2.2
Component:  Groups             |     Version:  2.1
 Severity:  major              |  Resolution:
 Keywords:  needs-patch        |

Comment (by imath):

 Replying to [comment:34 DJPaul]:

 First, i'm not necessarly a huge fan of the positionning i've suggested,
 it seems to me that it's the one that have the less impact on other parts
 of the template. Reason why i've took this road.

 > Alternatively, if we think most sites will have too many tabs already,
 or have made design decision assuming that that UL will only ever filter
 the main content, another suggestion is to put the button in the same UL
 as the "Order By" button: https://i.imgur.com/TV0rgIl.png

 I think, it's not a better idea, as this part is the '''subnav''' of
 Groups / My Groups, and it seems to me Create a group is not a subnav of
 Groups or My Groups. Here's an example in 2015 :

 > The proposal could be mitigated, for example, if the "Create Group" LI
 was right-aligned, so that it appeared above the "Order By" dropdown, and
 if it retained its existing button styling instead of it being a simple
 text link.

 I'd say why not, but when i went this road before submitting the first
 patch, i had a feeling the right part of the template was a bit
 "overloaded", reason why i thought it wasn't great. Here's an example in
 2015 :

 Now, if we are to take this road, i'd suggest to also move the search part
 in order to give some "air" to the right part of the template.
 Here's an example in 2015 :

 It's better in 2012 :)

 - the search can be a sub action of Groups or My groups
 - it avoids the negative margin applied to {{{#buddypress div.dir-
 search}}} which is really not great in 2015.
 - we are already doing this for the single group members template, here's
 a screenshot of it:


 - we need to also change the search positionning for the members
 directory, and the activity directory
 - At this place in the activity directory, we already have the '''RSS
 link''' :(

 Honestly, like boonebgorges i don't really care about the positionning of
 the button as soon as we try to make everything we can so that once the
 users will have upgraded to 2.2, they will be able to find all pieces into
 their template.

 IMHO, the positionning in 6008.03.patch is not the best, but is the least-
 worst :)

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6008#comment:39>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list