[buddypress-trac] [BuddyPress Trac] #6059: BP_Activity_Activity:get() doesn't respect 'max' parameter

[buddypress-trac]

#6059: BP_Activity_Activity:get() doesn't respect 'max' parameter
--------------------------+------------------------------
 Reporter:  dcavins       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Activity      |     Version:
 Severity:  minor         |  Resolution:
 Keywords:                |
--------------------------+------------------------------

Comment (by dcavins):

 Ha ha. What to do indeed.

 Well, I'm not sure it's not worth doing a whole bunch of work on it.
 Ideally, we could deprecate the argument where it's useless
 (`bp_has_notifications()`) or does something that just seems weird (like
 modifying the found-items count only--I can't imagine why you'd want to
 change the found-items count but not change the set of found items).

 Adding code comments where appropriate would go a long way. For instance,
 the docblock for `BP_Activity_Activity::get()` lies:

 {{{
          *     @type int|bool $max Maximum number of results to return.
          *                         Default: false (unlimited).
 }}}

 I can update the docblocks that need updating, if that seems useful to
 you.

 Can we not use 'max' in future components? :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6059#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac