[buddypress-trac] [BuddyPress Trac] #6059: BP_Activity_Activity:get() doesn't respect 'max' parameter

[buddypress-trac]

#6059: BP_Activity_Activity:get() doesn't respect 'max' parameter
--------------------------+------------------------------
 Reporter:  dcavins       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Activity      |     Version:
 Severity:  minor         |  Resolution:
 Keywords:                |
--------------------------+------------------------------

Comment (by boonebgorges):

 I've always found 'max' to be confusing and unclear. I guess I interpreted
 it as: if 'max' is set, then return this number of results max, regardless
 of 'per_page'. Then there would be a use case for using this alongside of
 'page'/'per_page'. Let's say you wanted the first 3 results, but starting
 with item 21. You could use 'page=3&per_page=10&max=3'. That being said,
 this is me trying to rationally reconstruct the purpose of a mysterious
 parameter.

 dcavins, before moving forward with anything, I'd appreciate if you could
 look at other places in BP for  the use of a 'max' param, and if
 necessary, in the logs, to try to get a better sense of what 'max' is/was
 intended to do. I want to make sure we don't break a huge number of things
 by changing the behavior here.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6059#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac