[buddypress-trac] [BuddyPress Trac] #5241: Notices occur when BP_ENABLE_ROOT_PROFILES is enabled

[buddypress-trac]

#5241: Notices occur when BP_ENABLE_ROOT_PROFILES is enabled
-------------------------------------+---------------------
 Reporter:  henrywright              |       Owner:  r-a-y
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  2.1
Component:  Core                     |     Version:  1.7
 Severity:  minor                    |  Resolution:  fixed
 Keywords:  needs-refresh has-patch  |
-------------------------------------+---------------------
Changes (by r-a-y):

 * owner:   => r-a-y
 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8821"]:
 {{{
 #!CommitTicketReference repository="" revision="8821"
 In `bp_core_load_template()`, reset post globals if we're on a non-
 directory page.

 If we're on a non-directory page, we are faking a WordPress page, so we
 must reset the WordPress post globals to avoid notices from appearing.
 The
 reset is done with the `bp_theme_compat_reset_post()` function and notably
 fixes notices when the root profiles feature is toggled.

 Commit also removes an unnecessary database query to determine whether
 we're on a BuddyPress directory page.  WordPress should have already made
 this determination before BuddyPress has reached this point in
 `bp_core_load_template()`.

 Fixes #5241.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5241#comment:23>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac