[buddypress-trac] [BuddyPress Trac] #5666: "Settings > Profile" hidden field doesn't list all field IDs

[buddypress-trac]

#5666: "Settings > Profile" hidden field doesn't list all field IDs
------------------------------------+------------------
 Reporter:  r-a-y                   |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  2.1
Component:  XProfile                |     Version:  2.0
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+------------------
Changes (by boonebgorges):

 * keywords:  needs-patch dev-feedback => dev-feedback has-patch


Comment:

 r-a-y, your suggested solution is clever, but I'm with Paul that it seems
 a bit overengineered for our edge case. I'd rather put a real fix in place
 for the problem (which is that `bp_the_profile_group_field_ids()` is the
 incorrect function to use here) and then build a backward compatibility
 layer on top of the fix, rather than leaving the broken status quo in
 place and then engineering a layer on top to fix it. (Does that make
 sense?)

 Anyway, 5666.02.patch is my suggested solution. Basically, don't use
 `bp_the_profile_group_field_ids()` anymore. Use
 `bp_the_profile_field_ids()` instead, which gets all field IDs available
 in the `$profile_template` loop. r-a-y, as you note, there is backward
 compatibility issue with sites that have overridden the template; I've
 chosen to fix that in a very direct way, inside of
 `bp_xprofile_action_settings()`. The backpat fix is a bit ugly, but I'd
 rather have the ugliness relegated to the backpat fix and keep the rest of
 the logic as elegant as possible. What do you think?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5666#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac