[buddypress-trac] [BuddyPress Trac] #5544: Custom component directory title

[buddypress-trac]

#5544: Custom component directory title
--------------------------+-----------------------------------
 Reporter:  imath         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  2.0
Component:  Core          |    Version:  2.0
 Severity:  normal        |   Keywords:  has-patch 2nd-opinion
--------------------------+-----------------------------------
 Since r8080, a new parameter 'directory_title' has been introduced to
 allow a component to set the directory page title.

 It's nice but i think the change applied to {{{bp_modify_page_title()}}}
 introduced a little regression considering 1.9.x.

 Before the page title of the custom component was set using
 {{{bp_get_name_from_root_slug()}}}, now the function
 {{{bp_get_directory_title()}}} first checks for component's
 'directory_title' argument  to see if it's set, which is always the case.
 Problem is that it's set with an empty value. So custom component that
 used to have a page title set thanks to
 {{{bp_get_name_from_root_slug()}}} will no more have a page title.

 The patch attached simply changes {{{isset}}} in favor of {{{! empty}}}
 which is fixing the issue.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5544>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac