[buddypress-trac] [BuddyPress] #5174: Depending on the context, group name should not be filterable

buddypress-trac noreply at wordpress.org
Tue Sep 17 00:55:26 UTC 2013

#5174: Depending on the context, group name should not be filterable
 Reporter:  imath                  |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Groups                 |     Version:  1.8.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |

Comment (by boonebgorges):

 A few thoughts on the proposal:

 a. IMHO (emphasis on "H" :) ), your technique in bp-sticky-groups is a bit
 hackish, and not something we want to encourage. The `bp_get_group_name`
 filter is for *the group name*; you are changing it to add markup, which
 is something beyond the name itself. I know that BP is not making it very
 easy for you to work here :), but hopefully the changes in #5173 will make
 it easier (you can then do `.sticky-group .item-title a` in your CSS, or
 something like that).

 b. I agree that there are some places where it might be argued that we
 don't want to apply exactly the same filters to the group name. The case
 of title attributes is one interesting case, if for no other reason that
 we have to escape it differently. However, instead of *removing* filters
 altogether, I think the most WordPress-ish way to solve the problem is to
 have *separate template functions* for these areas, with different

 What do you think?

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5174#comment:2>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list