[buddypress-trac] [BuddyPress] #5144: Don't set 'Create a Group' button as part of the title

buddypress-trac noreply at wordpress.org
Fri Sep 13 13:06:04 UTC 2013


#5144: Don't set 'Create a Group' button as part of the title
--------------------------+------------------------------
 Reporter:  rogercoathup  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Theme         |     Version:  1.7
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by hnla):

 The only thing I don't like about the approach is putting the onus on new
 themes to change something we already agree isn't correct- whatever the
 reasons for doing it that way at the time.

 We're saying first new theme has to add filter false, then has to deal
 with adding the button code themselves somewhere. Ideally one would run
 the button code based on if 'bp-legacy' so default condition was not
 inject into a heading tag where it has no context, in functions.php simply
 add the button code as  variable that can be placed where fancied.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5144#comment:5>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list