[buddypress-trac] [BuddyPress] #5151: Numeric Nicename sends PM's to the wrong user on large sites

[buddypress-trac]

#5151: Numeric Nicename sends PM's to the wrong user on large sites
--------------------------+---------------------
 Reporter:  DennisSmolek  |       Owner:  r-a-y
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  1.8.2
Component:  Messaging     |     Version:  1.6.2
 Severity:  major         |  Resolution:  fixed
 Keywords:  needs-patch   |
--------------------------+---------------------
Changes (by r-a-y):

 * owner:   => r-a-y
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7462"]:
 {{{
 #!CommitTicketReference repository="" revision="7462"
 Check username column first before sending a PM to a recipient.

 Previously, when sending a private message, a check was made against the
 user ID column first to determine who the recipient is.

 The problem with that is if:
   a. A site uses numeric user_login / user_nicenames only; and if
   b. A site has a large userbase

 That the recipient might be calculated incorrectly because of the check
 against the ID column first leading to unintended private messages being
 sent to the wrong user(s).

 This commit fixes this issue by reversing the look up so the user_login /
 user_nicename DB column is checked first, followed by the ID column being
 checked as a fallback if there is no initial match.

 Fixes #5151.

 Props DennisSmolek.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5151#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress