[buddypress-trac] [BuddyPress] #5029: display_comments=none does not work in activity loop

buddypress-trac noreply at wordpress.org
Tue May 28 23:33:50 UTC 2013


#5029: display_comments=none does not work in activity loop
--------------------------+------------------------------
 Reporter:  pollyplummer  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Activity      |     Version:  1.7
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------------------

Comment (by boonebgorges):

 It looks like the codex has been wrong for a long time. The default value
 of the `display_comments` param has been `threaded` since r2485. The codex
 should be updated to reflect the fact that `threaded` is the correct
 default value.

 FWIW, the default value of `display_comments` in `bp_activity_get()` is
 `false`. Maybe that's where the confusion originally came from.

 I do see that there is some funny business with strict type checking and
 the `display_comments` parameter in `BP_Activity_Activity::get()`, which
 may make it impossible to actually turn off comments. I'm going to write a
 couple unit tests and report back.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5029#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list