[buddypress-trac] [BuddyPress] #4857: Automatic download of translations from translate.wordpress.org

buddypress-trac noreply at wordpress.org
Mon May 6 11:02:21 UTC 2013

#4857: Automatic download of translations from translate.wordpress.org
 Reporter:  DJPaul                   |       Owner:  DJPaul
     Type:  task                     |      Status:  assigned
 Priority:  normal                   |   Milestone:  1.8
Component:  i18n                     |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |

Comment (by boonebgorges):

 This is looking really great, DJPaul. I think it's going to be a model for
 the WP implementation.

 I only ran into one issue while testing. In `buddypress_translate()` and
 `bp_admin_maybe_bump_update_count()`, you bail in the following

 if ( ! bp_is_network_activated() && is_network_admin() )
 if ( ! is_admin() || bp_is_network_activated() || ! bp_is_root_blog() )

 (a) AFAIK, on multisite, all plugin/theme updates happen on the network
 admin. So, the first instance prevents the update from ever taking place
 on an installation where BP is activated only on a single site.
 (b) The `bp_is_network_activated()` check in the second condition means
 that it'll never be possible to see/do an update when BP *is* network

 So, it looks like updates are totally blocked in every case where BP is
 running on Multisite.

 It seems to me that we can probably just drop both of these checks, though
 please let me know if I'm missing a problematic case. See 4857.02.patch.

 (Small note: in 4857.02.patch, I also un-aligned the equals-sign alignment
 in bp-loader.php. Bumpbot is going to change the the `version` and
 `db_version` values, which causes your patch not to apply. If you care
 about this alignment, maybe wait until committing to apply it.)

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4857#comment:12>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list