[buddypress-trac] [BuddyPress] #4955: Improvements to BP_Group_Extension

buddypress-trac noreply at wordpress.org
Sun May 5 18:06:00 UTC 2013

#4955: Improvements to BP_Group_Extension
 Reporter:  boonebgorges  |       Owner:  boonebgorges
     Type:  task          |      Status:  new
 Priority:  high          |   Milestone:  1.8
Component:  Groups        |     Version:
 Severity:  major         |  Resolution:
 Keywords:                |

Comment (by johnjamesjacoby):

 Patch looks good to me, let's think about getting this in soon. My updated
 patch is largely functionally the same as 4955.01.patch, with a few edits:

 * Random code clean-up.
 * Bail early where possible to avoid the extra indentation.
 * Added more strict comparison checking.
 * Added default values to class variables and method parameters.
 * Fixed a $this->is_initialized that should be $this->initialized.
 * Fixed a 'false;' that should be 'return false;

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4955#comment:8>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list