[buddypress-trac] [BuddyPress] #4869: BP Theme Compat & BuddyPress Widgets styles

buddypress-trac noreply at wordpress.org
Fri Mar 22 13:02:42 UTC 2013

#4869: BP Theme Compat & BuddyPress Widgets styles
 Reporter:  imath                       |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  1.7
Component:  Theme                       |     Version:  1.7
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |
Changes (by boonebgorges):

 * keywords:  has-patch => has-patch needs-unit-tests


 > If you think that's inefficient, check out BP_Component::includes() and
 BP's own bp_locate_template(), which both use a ton of is_file() and
 file_exists() checks when a file doesn't exist! :)

 Touché :)

 >  Or BP core could handle this much like it does the widget JS.

 This seems simpler to me. At least for 1.7, I think chances are pretty low
 that anyone is going to be creating BP template packs so extensive as to
 include widget stylesheets. For this release, let's roll imath's suggested
 styles into standalone stylesheets, and enqueue them from the widgets like
 we do with their js.

 As for r-a-y's patch, I'll try to test it this weekend. I think it's
 sensible to try to include this in 1.7, because it makes life much easier
 for people building their own theme packs, and we don't want to encourage
 people to make them more complicated than necessary. I'll try to build
 some unit tests for it too, if I get a few minutes.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4869#comment:7>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list