[buddypress-trac] [BuddyPress] #4949: Revise enqueue style locations for theme compat

buddypress-trac noreply at wordpress.org
Mon Jun 10 14:19:33 UTC 2013

#4949: Revise enqueue style locations for theme compat
 Reporter:  hnla                                 |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  low                                  |   Milestone:  1.8
Component:  Theme                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch 2nd-opinion needs-testing  |

Comment (by hnla):

 Updated patch just corrects the trailing slashed for directory structure.

 ''Not convinced of this patch validity even though I re-applied .02 to a
 clean copy of functions file from trunk ''
 Changes simply:
 $retval['location'] = trailingslashit( $location['uri'] ) .
 trailingslashit( $subdir ) . $file;

 Running tests on revised 02 patch look fine, file located correctly in
 parent or child themes in root level /my-theme/css/ or in /my-
 theme/community/css/ complete removal and we correctly fall back to plugin
 bp-legacy dir.

 Only glitch I could find was that the 'handle' is not correctly able to
 check if we are running in a child theme or simply in a parent or theme
 not set as a child, we always show 'bp-child-css-css'. I hacked things
 around a bit but couldn't find a suitable fix that didn't involve
 hardcoding those somewhere which didn't feel right, however if we are
 running from bp-legacy then we do correctly show 'bp-legacy-css-css' just
 not able to show bp-parent-css-css'

 $location_type is simply an array of the three locations so isn't in
 itself a check, in previous version we had to hardcode those strings.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4949#comment:8>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list