[buddypress-trac] [BuddyPress] #4116: add rules for html5 input types to bp-default theme

buddypress-trac noreply at wordpress.org
Mon Jun 3 12:09:15 UTC 2013

#4116: add rules for html5 input types to bp-default theme
 Reporter:  magnus78               |       Owner:  boonebgorges
     Type:  enhancement            |      Status:  closed
 Priority:  normal                 |   Milestone:  1.8
Component:  Theme                  |     Version:
 Severity:  normal                 |  Resolution:  fixed
 Keywords:  has-patch 2nd-opinion  |

Comment (by hnla):

 This ticket has some issues:
 >bp-default, one wants input fields to looks the same as the parent theme.
 But i still want to use input type="url" and other html5 goodies.
 Can understand that however BP-default was never built as a HTML5 running
 as it did/does with a trans xhtml dtd, thus building  - as you state - a
 child theme and having to adjust that factor would tend to suggest  -
 again as you end off with - that this is doable elsewhere and in fact is
 really part of the styling a true build theme or child theme should be
 dealing with.

 As for the patch I would suggest it's not a great idea; firstly we are now
 adding a series of selectors into the mix that may or may not be used,
 they definitely won't be in BP-default themes (unless they've been
 modified  at template level and not simply re-skinned) they also may not
 be used in the  new 1.7 legacy files unless the theme in use has made this
 provision (yes most might have but...)

 A group of selectors like this is unwieldy, and exist essentially to just
 counter the issue that might arise if one were  - perhaps - more correctly
 styling on the main form controls input, textarea, select but then running
 attendant risk of adversely styling radio,checkbox.

 In respect of bp-legacy  - not originally a focus of this ticket - we have
 a slight clash with this ticket/patch and the UI-Refresh ticket where we
 are attempting to unravel the styling where possible from the stylesheet
 and are now here adding it in; however that ruleset does exist so not
 technically a set new styles, and sadly given that bp-legacy styles were
 released without modification and thus in the wild we are between a rock
 hard place in terms of what can actually be stripped out from it.

 As for a 2nd-opinion this addition is unlikely to cause issues, but my
 preference given the above would be to not add anything now given we
 progress into a slightly different arena with template packs as a means
 forward in providing visually styled BP themes.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4116#comment:6>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list