[buddypress-trac] [BuddyPress] #5299: BP-Default missing notifications templates?

[buddypress-trac]

#5299: BP-Default missing notifications templates?
------------------------------------+--------------------
 Reporter:  modemlooper             |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  highest                 |   Milestone:  1.9.1
Component:  Notifications           |     Version:  1.9
 Severity:  blocker                 |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+--------------------
Changes (by boonebgorges):

 * keywords:  dev-feedback => dev-feedback has-patch
 * priority:  normal => highest
 * severity:  normal => blocker
 * milestone:  Awaiting Review => 1.9.1


Comment:

 Ugh, I don't know how we missed this.

 As things stand, users of bp-default or a child theme have the following
 options:

 1. Copy the bp-legacy templates into their themes and add a conditional in
 home.php (as modemlooper suggests)
 2. Disable the Notifications component, but then lose access to the
 notifications in the admin bar
 3. Do some sort of hack to prevent the Notifications nav item from being
 registered

 1 and 3 are unacceptably difficult for most people, and 2 is a regression.
 We have to come up with a better solution.

 a. The obvious choice is to include the notifications templates in bp-
 default. See 5299.01.patch. I know that we're EOLing bp-default, but I
 think the understanding was that we'd do that *after* 1.9, not *with* 1.9.
 And in any case, this represents a pretty large breakage with the theme.

 b. Bail out of registering the Notifications nav item when theme compat is
 disabled and no template are found in the parent/child theme. See
 5299.02.patch.

 On balance, I think that (a) is the right way to go. Feedback welcome.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5299#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress