[buddypress-trac] [BuddyPress] #5289: Single notifications not deleted from the unread or read notifications lists when the item in question is deleted in 1.9 beta 2

[buddypress-trac]

#5289: Single notifications not deleted from the unread or read notifications
lists when the item in question is deleted in 1.9 beta 2
---------------------------+------------------------------
 Reporter:  henrywright    |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Notifications  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:                 |
---------------------------+------------------------------

Comment (by imath):

 Hi,

 As emails sent cannot be deleted, there will always be a risk that the
 user arrives on a page with no content. So first i thought, maybe the
 notifications component should follow this behavior and act like a log of
 past interactions.

 Then, i've noticed groups invite notifications were deleted in case an
 invite has been removed. When a group or a user is removed all
 notifications are also deleted. In case a friendship is deleted, the
 action was here but not fired.

 I guess, the behavior for demoted users in groups, activity (@mention) and
 message thread completely deleted (that is to say all members deleted the
 message see #5254) should as a result follow the same behavior than
 previous cases.

 Now the item_id for messages component in bp_notifications is not the
 thread_id but the message id, so i add to edit the
 BP_Messages_Thread::delete function to get that message id and add a new
 action to hook the function to delete the notifications.

 I also edited the hook for friendship case, as it was not fired due to a
 missing letter :
 {{{friends_friendship_withdrawn}}} instead of
 {{{friends_friendship_withdrawn}}}

 So i suggest the 5289.diff attached to this ticket.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5289#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress