[buddypress-trac] [BuddyPress] #4627: bp_core_fetch_avatar html pref checking should use !empty (again)

buddypress-trac noreply at wordpress.org
Thu Oct 25 12:03:04 UTC 2012

#4627: bp_core_fetch_avatar html pref checking should use !empty (again)
 Reporter:  magnus78      |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Core          |    Version:
 Severity:  normal        |   Keywords:  has-patch
 Ok, so in #4215 the $html strict parameter checking was finally backed out
 since html='false' didn't work out in some existing theme code. (I just
 found out, trac doesn't send email to OP by default?)

 I think we agreed it's still a good idea. I'd propose to do it, but just
 fix the 'false' case to by filter_var($html, FILTER_VALIDATE_BOOLEAN);

 With this you can have html=false, html=0, html=no, html=true, html=1 etc.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4627>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list