[buddypress-trac] [BuddyPress] #3741: BuddyPress should have theme compatibility

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Sat Oct 13 08:30:44 UTC 2012

#3741: BuddyPress should have theme compatibility
 Reporter:  johnjamesjacoby  |       Owner:  johnjamesjacoby
     Type:  enhancement      |      Status:  new
 Priority:  highest          |   Milestone:  1.7
Component:  Theme            |     Version:
 Severity:  critical         |  Resolution:
 Keywords:  dev-feedback     |

Comment (by johnjamesjacoby):

 Replying to [comment:33 r-a-y]:
 > register.01.patch adds support for the registration / activation
 templates in theme-compat mode and does a few other things:
 > * Introduces `bp_is_theme_compat()` to tell if theme compatibility is
 > * Navigating to `wp-login.php?action=register` redirects to the BP
 registration page again
 > * Accessing a restricted item like `/members/USERNAME/settings/` did not
 show the login form.  This is addressed by defaulting the `mode` in
 `bp_core_no_access()` to `2` when theme compat is running.

 I don't think this function is necessary. The 'mode' bit in
 bp_core_no_access() is weird, too. We should just always redirect to wp-
 login.php, and also hooking into 'login_init' (or a more specific login
 page action) and redirecting from there if we can tell that a more
 suitable theme-side page exists.

 Trying to predict "whether a theme has theme compat enabled" defeats the
 purpose of including theme compatibility in BuddyPress core. It's supposed
 to always be on, only kicking in when no template file is found in the
 parent/child theme stack.

 Allowing themes to opt into or out-of using it via a switch, theme
 support, filter, or otherwise, is a slippery slope I'd rather we didn't
 fall into, at least until we absolutely need a way to do it in core
 ourselves, and I don't think this is that case.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3741#comment:40>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list