[buddypress-trac] [BuddyPress] #4571: Changes in Gravatar APIs result in failed fallback on default avatars

[buddypress-trac at lists.automattic.com]

#4571: Changes in Gravatar APIs result in failed fallback on default avatars
--------------------------+-----------------------------
 Reporter:  boonebgorges  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Core          |     Version:
 Severity:  major         |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------------
Changes (by r-a-y):

 * keywords:   => has-patch


Comment:

 In 01.patch, I've addressed the problem of Gravatar's default avatars
 failing by directly using Gravatar's CDN-hosted 'mystery-man' avatar.

 The main fix for this is line 344 of the patch:
 `apply_filters( 'bp_core_mysteryman_src', 'mm', $grav_size );`

 Changing to 'mm' automatically uses Gravatar's CDN-hosted 'mystery-man'
 avatar instead of our own, bundled version.

 View Gravatar's docs on this:
 https://en.gravatar.com/site/implement/images/#default-image

 This eliminates the problems with our bundled version being behind any
 firewalls and on local development sites.

 This should also be backwards-compatible with anyone using the
 '`bp_core_mysteryman_src`' filter, unless the avatar is not publicly-
 accessible.

 ---

 I've also taken the liberty of changing our locally-hosted 'mystery-man'
 avatars to use Gravatar as well.

 This is reflected in the changes to bp_core_avatar_default() and
 bp_core_avatar_default_thumb().

 These functions are only used if their respective constants are not
 defined; this part of the patch can be omitted if deemed sucky!

 Let me know what you think.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4571#comment:10>
BuddyPress <http://buddypress.org/>
BuddyPress