[buddypress-trac] [BuddyPress] #3980: bp_activity_at_name_filter_updates() causes activity to be saved twice

[buddypress-trac]

#3980: bp_activity_at_name_filter_updates() causes activity to be saved twice
------------------------------------+-----------------------------
 Reporter:  r-a-y                   |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Future Release
Component:  Activity                |     Version:  1.5
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------------

Comment (by boonebgorges):

 Thanks for patching it, r-a-y!

 I think this approach looks great. I'm in favor of `with-stuffing`, not
 only because I'm still in the Thanksgiving spirit, but also because it's
 far more elegant, whatever you think about global variables, to run the
 find_mentions() function just once.

 Just so I'm clear: the returned value of `bp_activity_find_mentions()` is
 changed only in that the array keys are now user ids, right? I want to
 make sure that there are no backward compatibility problems with anyone
 using `bp_activity_find_mentions()` in a plugin. If it's just a matter of
 different indexes, I doubt there will be any problems.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3980#comment:12>
BuddyPress <http://buddypress.org/>
BuddyPress