[buddypress-trac] [BuddyPress] #3980: bp_activity_at_name_filter_updates() causes activity to be saved twice

buddypress-trac noreply at wordpress.org
Thu Nov 22 19:57:13 UTC 2012


#3980: bp_activity_at_name_filter_updates() causes activity to be saved twice
--------------------------+-----------------------------
 Reporter:  r-a-y         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Activity      |     Version:  1.5
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+-----------------------------

Comment (by r-a-y):

 Returning to this issue again, I can't see a decent approach to get around
 the duplicate action firing.

 [https://buddypress.trac.wordpress.org/ticket/3980#comment:2 The workflow
 described by Boone] will work if no @mention is found, which is better
 than what we currently have.

 However, if we find an @mention, the activity content will need to be
 saved for a second time.  This means we'll be firing any activity save
 hooks twice.

 One solution is we could add a parameter to `BP_Activity_Activity::save()`
 so we could bypass any `do_action()` calls there.  Yes, this would be
 rather ugly.

 Any other ideas?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3980#comment:7>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list