[buddypress-trac] [BuddyPress] #4077: Certain Friends-related URLs 404

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Sun May 27 14:19:41 UTC 2012

#4077: Certain Friends-related URLs 404
 Reporter:  boonebgorges  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  1.6
Component:  Friends       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |

Comment (by boonebgorges):

 Here's a rundown of what's happening.

 Before BP 1.2, the My Friends list could be ordered by Recently Active,
 Alphabetically, or Newest filters. The following functions were related to
 this functionality:

 - `bp_friends_header_tabs()` - Displayed the order filters
 - `bp_friends_filter_title()` - Set the title of the Friends page
 conditionally based on the desired order
 - `friends_get_recently_active()`, `friends_get_alphabetically()`,
 `friends_get_newest()` - Formerly used directly from template tags to call
 up the appropriate list of friends

 None of these functions are used anymore in BP, since 1.2. I'm going to
 deprecate them, and I'm going to remove the problematic URLs from the
 places they've leaked through to the current BP.

 There is a further question as to whether we want to support the
 filtering/ordering of member lists based on URL parameters ($_GET).
 Currently, the relevant logic lives in `bp_dtheme_ajax_querystring()`,
 which parses certain `$_POST` parameters (from AJAX requests) with
 parameters from the `$_COOKIE` global. The hard part about introducing
 `$_GET` into this equation is knowing how the order of precedence should
 work. It seems to me that `$_GET` should always *win*, since it doesn't
 make sense to ever have results that don't match the URL in the address
 bar, but this will cause all sorts of funny issues with AJAX refreshing.
 For the moment, I think we can safely just ignore the issue, but at some
 point in the future we may want to consider rethinking some of this (maybe
 with a theme rewrite).

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4077#comment:2>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list