[buddypress-trac] [BuddyPress] #4066: Recently Active Members Sidebar Widget Bug

[buddypress-trac at lists.automattic.com]

#4066: Recently Active Members Sidebar Widget Bug
----------------------------+--------------------
 Reporter:  slickremix.com  |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  1.6
Component:  Core            |     Version:  1.5.4
 Severity:  minor           |  Resolution:
 Keywords:                  |
----------------------------+--------------------
Changes (by boonebgorges):

 * severity:  normal => minor
 * milestone:  Awaiting Review => 1.6


Comment:

 Confirmed. This bug is related to a hardcoded method we use for returning
 false from bp_has_members() when viewing the 'requests' page. In an ideal
 world, we would have fine-grained arguments for requesting users based on
 friendship status, but this would require a large rewrite of
 bp_has_members() stack, which is probably not worth it for this somewhat
 obscure bug.

 Since we are currently using the 'include' parameter of bp_has_members()
 to do friendship request filtering, I have opted for a technique that
 allows a 0 value to be respected in BP_Core_User::get_users(). That way,
 the default value of $include - false - will continue to operate on the
 same logic as before, as will int/string single values, while values of 0
 or '0' will append "AND 0 = 1" to the sql query.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4066#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress