[buddypress-trac] [BuddyPress] #4258: Straighten out group forum (bbPress 1.x) integration

[buddypress-trac at lists.automattic.com]

#4258: Straighten out group forum (bbPress 1.x) integration
--------------------------+-------------------------------------
 Reporter:  boonebgorges  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  highest       |  Milestone:  Awaiting Review
Component:  Core          |    Version:
 Severity:  critical      |   Keywords:  has-patch needs-testing
--------------------------+-------------------------------------
 During the 1.6 dev cycle, some modifications were made to the admin to
 make way for the full transition to bbPress 2.x support. (See #3598.)
 Since the team has decided to release 1.6 without this feature, we need to
 do some cleanup to make sure that bbPress 1.x forums can still be
 installed and used inside of groups - basically, reverting to the "Group
 Forums/Sitewide Forums" setup from BP 1.5.x.

 I've attached a patch that should make the necessary reversions. I've
 tested the following:
 - Forum installation (MS and non-MS)
 - Group creation with forums activated
 - Posting/viewing group forums

 All seems to be working, though it would be great to have it tested by a
 few others before committing.

 This patch also fixes a strange bug that caused bb-config.php creation to
 fail when one of the WP salts contains the characters `?>` next to each
 other.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4258>
BuddyPress <http://buddypress.org/>
BuddyPress