[buddypress-trac] [BuddyPress] #4339: Repeat footer - eq4.us

[buddypress-trac at lists.automattic.com]

#4339: Repeat footer - eq4.us
-------------------------------------------------+-------------------------
 Reporter:  rbasmaji                             |       Owner:
     Type:  defect (bug)                         |  johnjamesjacoby
 Priority:  normal                               |      Status:  assigned
Component:  Theme                                |   Milestone:  Awaiting
 Severity:  normal                               |  Review
 Keywords:  needs-patch needs-testing dev-       |     Version:  1.6-beta
  feedback                                       |  Resolution:
-------------------------------------------------+-------------------------
Changes (by boonebgorges):

 * keywords:  needs-patch needs-testing => needs-patch needs-testing dev-
     feedback
 * owner:  rbasmaji => johnjamesjacoby


Comment:

 The problem can be traced to
 https://buddypress.trac.wordpress.org/changeset/5736. Prior to this
 change, the 'bp_footer' hook was called directly in footer.php (as was the
 `wp_footer()` function). Themes that were based on bp-default copied this
 implementation. After r5736, our 'bp_footer' is hooked to 'wp_footer',
 which means that in these 1.5-era themes, the 'bp_footer' action is fired
 twice: once when it's called manually, and once when it's hooked to
 'wp_footer'.

 This is probably going to cause similar problems for loads of WP themes
 (even children of bp-default are highly likely to have overridden
 footer.php), so I'd advocate reverting the change, and moving the
 do_action() back into footer.php. On a theme rewrite in a future version,
 we can go back to JJJ's method.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4339#comment:7>
BuddyPress <http://buddypress.org/>
BuddyPress