[buddypress-trac] [BuddyPress] #4708: max-width: 100% on images breaks avatar cropping

buddypress-trac noreply at wordpress.org
Mon Dec 10 17:12:39 UTC 2012

#4708: max-width: 100% on images breaks avatar cropping
 Reporter:  boonebgorges  |      Owner:  boonebgorges
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  1.7
Component:  Core          |    Version:  1.6
 Severity:  normal        |   Keywords:  has-patch dev-feedback
 I've come across a number of themes that are using the following CSS to
 help make images more responsive:

 img { max-width: 100%; height: auto; }

 Setting a max-width on all images has a tendency to break our
 implementation of jcrop, however, by throwing all images out of
 proportion, layering images in a weird way, and other such garbage.

 I've attached a patch with my suggested fix, which works well on every
 theme I've tried it with, and seems to be specific enough not to cause any
 more problems. I'm posting here before committing, though, because I want
 someone more familiar with responsive techniques to have a look first. In
 particular, what will this do to the avatar cropper on small devices?

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4708>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list