[buddypress-trac] [BuddyPress] #4060: Improve performance of BP_Core_User::get_users()

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Sat Aug 25 21:24:54 UTC 2012

#4060: Improve performance of BP_Core_User::get_users()
 Reporter:  shanebp                              |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  highest                              |   Milestone:  1.7
Component:  Members                              |     Version:  1.2.9
 Severity:  critical                             |  Resolution:
 Keywords:  2nd-opinion has-patch needs-testing  |
  dev-feedback                                   |

Comment (by johnjamesjacoby):

 Huge wins overall. Outstanding work.

 Attached patch v2:
 * Cleans up whitespace, comments, indentation, etc... (as if you expected
 anything else)
 * Removes test cases for commented out bugs (I tend to agree with your
 assessment here)
 * Decouples bp_is_active() checks from populate_extras() method, and moves
 them into the xprofile and friends components
 * Adds some @todo's for other places bp_is_active() should be decoupled.
 * Testing this on a small dataset, the queries are faster but it results
 in more of them (probably because of duplicate xprofile primary name field
 ID querying).
 * I'm okay with the 'last_activity' behavior changing; it's something that
 comes up enough as unexpected where even though it's 'working as designed'
 it's still a poor design.

 Overall, this is the direction we should go. I'm comfortable committing
 this in early, and iterating on it over time. Getting this in early allows
 for testing this with other user related queries to look for
 optimizations; friends, group members, activity streams, etc...

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4060#comment:28>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list