[buddypress-trac] [BuddyPress] #3622: bp_get_sitewide_activity_feed_link()

[buddypress-trac at lists.automattic.com]

#3622: bp_get_sitewide_activity_feed_link()
-------------------------------------------------+-------------------------
 Reporter:  webraket                             |       Owner:
     Type:  defect                               |      Status:  new
 Priority:  normal                               |   Milestone:  1.5.1
Component:  Activity                             |     Version:  1.5
 Severity:  major                                |  Resolution:
 Keywords:  has-patch needs-testing reporter-    |
  feedback                                       |
-------------------------------------------------+-------------------------

Comment (by webraket):

 Replying to [comment:7 boonebgorges]:
 > The patch 3622.02 is attached to this ticket. If you're reading this in
 an email, click through to it.
 >
 > > Sorry, I don't trust bp_init at the moment.
 >
 > bp_init is itself hooked to init.
 http://buddypress.trac.wordpress.org/browser/trunk/bp-core/bp-core-
 hooks.php#L17
 >
 > > you can't add actions to wp_ajax{callback_function} from inside
 classes/functions hooked to bp_init.
 >
 > Load order was changed in 1.5, so you may be right. I suggest that you
 load your base class at bp_loaded. This is what the new BP Skeleton
 Component will recommend when it comes out in the upcoming days:
 https://github.com/boonebgorges/buddypress-skeleton-
 component/blob/1.5-compat/includes/bp-example-loader.php#L364

 bp_loaded is hooked to plugins_loaded, that seems a bit too early.

 I like to construct my base class at least after wordpress loaded the
 current user to make use of functions like is_super_admin() etc.

 I mostly hook my base classes (for BuddyPress only plugins) from bp_init,
 I expect this to still be fine just not for some functions anymore like
 wp_ajax (and probably some other functions).

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3622#comment:10>
BuddyPress <http://buddypress.org/>
BuddyPress