[buddypress-trac] [BuddyPress] #3574: Deleting comment from update - too much spacing

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Mon Oct 10 20:15:52 UTC 2011

#3574: Deleting comment from update - too much spacing
 Reporter:  xeqta                    |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  1.5.1
Component:  Activity                 |     Version:
 Severity:  trivial                  |  Resolution:
 Keywords:  has-patch needs-testing  |
Changes (by boonebgorges):

 * keywords:  needs-patch => has-patch needs-testing


 The root problem is actually pretty simple - the has-comments class on the
 activity item's <li> element is not removed when the last comment is
 deleted. See 3574.01.patch for a solution.

 I'll note that 3574.01.patch looks like a bigger change than it actually
 is. In order to make the new_count check at the end as efficient as
 possible, I wanted to cast the objects as variables rather than traversing
 the DOM more than necessary. That said, I'm happy to have this punted if
 others think it's too significant a theme change for a dot-dot release.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3574#comment:6>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list