[buddypress-trac] [BuddyPress] #3243: CSS files need commenting and organisation

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Sat May 28 17:40:29 UTC 2011


#3243: CSS files need commenting and organisation
--------------------------+-------------------------
  Reporter:  karmatosed   |      Owner:  karmatosed
      Type:  enhancement  |     Status:  accepted
  Priority:  normal       |  Milestone:  1.3
 Component:  Theme        |    Version:  1.2
Resolution:               |   Keywords:  needs-patch
--------------------------+-------------------------

Comment (by karmatosed):

 Attached are 2 diff files.

 1.  The reset.css needs to be removed under _inc/css if this is approved -
 sorry wasn't sure how / if to do that via diff.

 2.  Reset.css has been included and functions.diff shows this now not
 being loaded.

 3.  Default.diff shows all the changes.  Nothing should have been removed
 and I have done testing.

 I will continue testing but suggest as such a change not just me tests
 this one.

 Some changes from suggested format have been done as the code was explored
 more.

 To recap the content at the top now is this with a welcome message:


 {{{
 /*--------------------------------------------------------------
 Hello, this is the main BuddyPress Default theme file.
 Please see adminbar.css in this folder for the adminbar styling.
 ----------------------------------------------------------------
 >>> TABLE OF CONTENTS:
 ----------------------------------------------------------------
 1.0 - Reset - Based on work by Eric Meyer
 2.0 - BuddyPress
         2.1 - Activity
              2.1.2 - Activity Listing
              2.1.3 - Activity Comments
         2.2 - Admin Bar
         2.3 - Ajax Loading
         2.4 - Data Tables
         2.5 - Directories - Members, Groups, Blogs, Forums
         2.6 - Forum Topics
         2.7 - Items
             2.7.1 - Item Headers
             2.7.2 - Item Lists - Activity, Friend, Group Lists
             2.7.3 - Item Tabs
         2.8 - Private Messaging Threads
 4.0 - Forms
         4.1 - Buttons
         4.2 - Error / Success Messages
 5.0 - Navigation
         5.1 - Pagination
 6.0 - Structure
         6.1 - Content
         6.2 - Header
         6.3 - Footer
         6.4 - Sidebar
 7.0 - Text Elements
     7.1 - Headers
 8.0 - WordPress
         8.1 - Alignments
         8.2 - Comments
         8.3 - Gallery
         8.4 - Images
         8.5 - Lists
         8.6 - Posts
 --------------------------------------------------------------*/
 /*--------------------------------------------------------------
 >>> START STYLES
 --------------------------------------------------------------*/
 }}}

 This probably isn't the ultimate method to do this all I think what we
 have here is a good step on the road to making this file more accessible.
 Then we can build on this with later patches.

-- 
Ticket URL: <https://trac.buddypress.org/ticket/3243#comment:11>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list