[buddypress-trac] [BuddyPress] #3429: BP_Embed tweaks

[buddypress-trac at lists.automattic.com]

#3429: BP_Embed tweaks
-----------------------+------------------------------
 Reporter:  r-a-y      |       Owner:
     Type:  defect     |      Status:  new
 Priority:  normal     |   Milestone:  Awaiting Review
Component:  Core       |     Version:  1.5
 Severity:  normal     |  Resolution:
 Keywords:  has-patch  |
-----------------------+------------------------------

Comment (by r-a-y):

 Just tested.

 What you're seeing on testbp.org is the bug in point 2.  The
 [http://buddypress.trac.wordpress.org/browser/trunk/bp-core/bp-core-
 classes.php#L1180 $id] should be empty for an activity comment or an
 expanding activity item, but because $id is also
 [http://buddypress.trac.wordpress.org/browser/trunk/bp-core/bp-core-
 classes.php#L1171 defined above the code], BP_Embed thinks that the $id
 exists, but in actual fact it's a string of the embed handler, which isn't
 numeric.

 The second patch makes this a little clearer.

 When you patch just point 2, you'll see that embeds for recursive activity
 comments and expanded activity items will not show up.

 The reason why is recursive activity comments and the expanding activity
 item do not use a real activity loop ( bp_has_activities() ).  The current
 code in 1.5-beta-1 ( bp_activity_embed() ) only checks if an activity ID
 exists during the activity loop.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3429#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress