[buddypress-trac] [BuddyPress] #2222: Double membership bug

[buddypress-trac at lists.automattic.com]

#2222: Double membership bug
--------------------+-------------------------------------------------------
 Reporter:  3sixty  |       Owner:       
     Type:  defect  |      Status:  new  
 Priority:  major   |   Milestone:  1.2.4
Component:  Groups  |    Keywords:       
--------------------+-------------------------------------------------------

Comment(by boonebgorges):

 I've confirmed this bug too.

 Right now groups_invite_user checks for duplicate invitations, and
 groups_send_membership_request checks for duplicate requests, but they
 don't reference each other at all, which results in two entries in the
 group members table.

 There are a few ways to handle it:
 1) Don't let an invite (memb request) be sent if a membership request
 (invite) already exists. Send an error back to the inviter that says "x
 has already requested membership" (in the case of invitations) or back to
 the requester that says "You've already been invited" (in the case of
 membership requests).
 2) When you have both a membership request and an invitation, have the
 member join the group. The logic: an invitation to join a group is more or
 less equivalent, at least from a privacy point of view, to the approval of
 a request. The problem is that it might be a bit confusing to request
 membership and then all of a sudden find yourself joined. Also, only
 admins can approve requests, while any group member can send invites - so
 I guess they're not exactly alike.
 3) Allow invites and requests for a user/group pair to coexist, but make
 sure that the other one is cleared when the invitation is accepted/the
 notification is approved, so that you don't get the problem of double
 membership.

 I guess (3) seems the most natural to me.

-- 
Ticket URL: <http://trac.buddypress.org/ticket/2222#comment:4>
BuddyPress <http://buddypress.org/>
BuddyPress