[Spam 6.50] [bbDev] [1603] trunk/bb-admin/themes.php: urlencode theme names in querystring.

[Michael D Adams]

Not having looked at the function, should bb_get_uri() urlencode all  
those values in the second argument, or does that break more than it  
fixes?

On Jul 23, 2008, at 11:59 AM, m at wordpress.org wrote:

> Revision
> 1603
> Author
> sambauers
> Date
> 2008-07-23 18:59:47 +0000 (Wed, 23 Jul 2008)
> Log Message
>
> urlencode theme names in querystring. Fixes #902
> Modified Paths
>
> trunk/bb-admin/themes.php
> Diff
>
> Modified: trunk/bb-admin/themes.php (1602 => 1603)
> --- trunk/bb-admin/themes.php	2008-07-23 17:07:40 UTC (rev 1602)
> +++ trunk/bb-admin/themes.php	2008-07-23 18:59:47 UTC (rev 1603)
> @@ -52,7 +52,7 @@
>  	$theme_directory = bb_get_theme_directory( $theme );
>  	$theme_data = file_exists( $theme_directory . 'style.css' ) ?  
> bb_get_theme_data( $theme ) : false;
>  	$screen_shot = file_exists( $theme_directory .  
> 'screenshot.png' ) ? clean_url( bb_get_theme_uri( $theme ) .  
> 'screenshot.png' ) : false;
> -	$activation_url = bb_get_uri('bb-admin/themes.php', array('theme'  
> => $theme), BB_URI_CONTEXT_A_HREF + BB_URI_CONTEXT_BB_ADMIN);
> +	$activation_url = bb_get_uri('bb-admin/themes.php', array('theme'  
> => urlencode($theme)), BB_URI_CONTEXT_A_HREF +  
> BB_URI_CONTEXT_BB_ADMIN);
>  	$activation_url = clean_url( bb_nonce_url( $activation_url,  
> 'switch-theme' ) );
>  ?>
>  	<li<?php alt_class( 'theme', $class ); ?>>
> _______________________________________________
> bbDev mailing list
> bbDev at lists.bbpress.org
> http://lists.bbpress.org/mailman/listinfo/bbdev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://comox.textdrive.com/pipermail/bbdev/attachments/20080724/0962e6c0/attachment-0001.htm