[Bb-trac] Re: [bbPress] #1003: regex parsing error on page_number_links when pretty permalinks off

[bbPress]

#1003: regex parsing error on page_number_links when pretty permalinks off
----------------------+-----------------------------------------------------
 Reporter:  _ck_      |        Owner:                    
     Type:  defect    |       Status:  new               
 Priority:  normal    |    Milestone:  1.0-beta & XML-RPC
Component:  Back-end  |      Version:  1.0-beta (trunk)  
 Severity:  normal    |   Resolution:                    
 Keywords:            |  
----------------------+-----------------------------------------------------
Comment (by _ck_):

 Okay here's the issue:

 Escaping the `?` is the right thing to do and removes the error.

 However the problem is not completely solved, because if there are other
 things on the url line, what happens over in
 `function bb_paginate_links( $args = '' ) {`
 is that if the link is to the 1st page, the page number AND THE
 QUESTIONMARK is removed entirely, leaving the `&` as the next item in the
 line.

 Can't do that.
 Line 222 in functions.wp-core.php

 `
 $link = str_replace( '%_%', 2 == $current ? '' : $format, $base );
 `

 Very bad. The `''` removed the entire `?page=` part leaving in my example
 `search.php&q=test`

 Needs a workaround.

-- 
Ticket URL: <http://trac.bbpress.org/ticket/1003#comment:2>
bbPress <http://bbpress.org/>
Innovative forum development