[Bb-trac] Re: [bbPress] #937: 100k PHPmailer should be a plugin and not in the core

[bbPress]

#937: 100k PHPmailer should be a plugin and not in the core
----------------------+-----------------------------------------------------
 Reporter:  _ck_      |        Owner:             
     Type:  defect    |       Status:  closed     
 Priority:  low       |    Milestone:             
Component:  Back-end  |      Version:  1.0-alpha-1
 Severity:  minor     |   Resolution:  wontfix    
 Keywords:            |  
----------------------+-----------------------------------------------------
Changes (by mdawaffe):

  * status:  new => closed
  * resolution:  => wontfix
  * milestone:  1.0-beta & XML-RPC =>

Comment:

 I agree that PHP Mailer is not perfect, but PHP Mailer is proven to be a
 better solution than bbPress' old mail() solution.  WordPress made a
 similar transition (also not without controversy).

 As an anecdote, I recently used PHP Mailer's SMTP wrapper to send hundreds
 of thousands of emails over a short period of time and have since improved
 my code (not PHP Mailer's) to speed up that process by a multiplicative
 factor.

 PHP Mailer is never loaded unless you're actually sending an email.  If
 you plug bb_mail() as a Swift Mailer wrapper or a mail() wrapper,
 PHPMailer will never be loaded.

 Including this "100k of additional code" in the distribution does not
 impact page load times, memory usage, or any other efficiency measure: the
 file is almost never loaded.  There may be 1M of PHP files per install,
 but not all of that is loaded for any given page load.  We could package
 bbPress with a 30M how-to video and similarly not effect your site's
 performance.

 Also, you don't know that you're one of the "1% [of people] with hosting
 issues" until it's too late: your users can't login because they never got
 an email.

 If bbPress is plugged or enhanced to send more emails, and someone
 demonstrates that PHP Mailer truly is slowing things down, and that an
 alternative exists with the needed features and cross-compatibility, we
 can decide to use something else.

 Until then, you can always plug bb_mail() to use something that better
 suits your needs.

 Marking this as wontfix for now.  Let's address this again when we get
 real world data.

-- 
Ticket URL: <http://trac.bbpress.org/ticket/937#comment:6>
bbPress <http://bbpress.org/>
Innovative forum development