From bb-trac at lists.bbpress.org Fri Aug 1 03:53:10 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Fri Aug 1 04:09:30 2008 Subject: [Bb-trac] [bbPress] #909: request for debug_backtrace in SAVEQUERIES via db-mysql class Message-ID: <035.85c9d4d33314ab76f016a3375342f926@lists.bbpress.org> #909: request for debug_backtrace in SAVEQUERIES via db-mysql class -------------------------+-------------------------------------------------- Reporter: _ck_ | Owner: Type: enhancement | Status: new Priority: low | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: minor | Keywords: -------------------------+-------------------------------------------------- Could we get the debug_backtrace to track the functions in `db-mysql.php` like they use on the WordPress side? Not sure if this will happen automatically via BackPress or not. in `db-mysql.php` around line 167 would be replaced: from: {{{ $this->queries[] = array( $query . ' server:' . $current_connection, $this->timer_stop() ); }}} to: {{{ $this->queries[] = array( $query, $this->timer_stop(), $this->get_caller() ); }}} and this function would need to be added: {{{ function get_caller() { // requires PHP 4.3+ if ( !is_callable('debug_backtrace') ) return ''; $bt = debug_backtrace(); $caller = ''; foreach ( $bt as $trace ) { if ( @$trace['class'] == __CLASS__ ) continue; elseif ( strtolower(@$trace['function']) == 'call_user_func_array' ) continue; elseif ( strtolower(@$trace['function']) == 'apply_filters' ) continue; elseif ( strtolower(@$trace['function']) == 'do_action' ) continue; $caller = $trace['function']; break; } return $caller; } } }}} -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Fri Aug 1 19:55:27 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Fri Aug 1 22:59:40 2008 Subject: [Bb-trac] [bbPress] #910: Incorrect Doctype for the default skin Message-ID: <038.9735f65b26aafb7ab9519d2d13ee9566@lists.bbpress.org> #910: Incorrect Doctype for the default skin -----------------------+---------------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-alpha (trunk) Severity: normal | Keywords: -----------------------+---------------------------------------------------- Use this doctype for the skin: and not the bad 1.1. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Fri Aug 1 19:59:10 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Fri Aug 1 23:04:22 2008 Subject: [Bb-trac] [bbPress] #911: Create a bb-content with templates, plugins and languages, like in Wordpress Message-ID: <038.46c20226d4b17bf336ee383a09789197@lists.bbpress.org> #911: Create a bb-content with templates, plugins and languages, like in Wordpress ----------------------------+----------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-alpha (trunk) Severity: normal | Keywords: ----------------------------+----------------------------------------------- Create a /bb-content folder with: /bb-templates, /bb-plugins and /bb- includes/languages , like Wordpress -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Fri Aug 1 20:01:43 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Fri Aug 1 23:07:41 2008 Subject: [Bb-trac] [bbPress] #912: Upgrade to Prototype 1.6.0.2 Message-ID: <038.2cb3b4d72c5a665bd1f221417a258d6d@lists.bbpress.org> #912: Upgrade to Prototype 1.6.0.2 ----------------------------+----------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-alpha (trunk) Severity: normal | Keywords: ----------------------------+----------------------------------------------- Use the new version of Prototype: http://www.prototypejs.org/download , in /bb-includes/js folder -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Fri Aug 1 20:16:59 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Fri Aug 1 23:28:45 2008 Subject: [Bb-trac] Re: [bbPress] #912: Upgrade to Prototype 1.6.0.2 In-Reply-To: <038.2cb3b4d72c5a665bd1f221417a258d6d@lists.bbpress.org> References: <038.2cb3b4d72c5a665bd1f221417a258d6d@lists.bbpress.org> Message-ID: <047.93508918707735d48227ff58aef5e2e6@lists.bbpress.org> #912: Upgrade to Prototype 1.6.0.2 ----------------------------+----------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: closed Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-alpha (trunk) Severity: normal | Resolution: wontfix Keywords: | ----------------------------+----------------------------------------------- Changes (by Null): * status: new => closed * resolution: => wontfix Comment: Let's not. The idea is to let prototype completely go and merge to jquery and interface(jquery UI). Updating prototpe will give problems in the long run if people (plugins (builders)) keep depending on it. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Fri Aug 1 23:38:21 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sat Aug 2 03:23:42 2008 Subject: [Bb-trac] Re: [bbPress] #911: Create a bb-content with templates, plugins and languages, like in Wordpress In-Reply-To: <038.46c20226d4b17bf336ee383a09789197@lists.bbpress.org> References: <038.46c20226d4b17bf336ee383a09789197@lists.bbpress.org> Message-ID: <047.01a18b9f8d31116538541ead44169801@lists.bbpress.org> #911: Create a bb-content with templates, plugins and languages, like in Wordpress ----------------------------+----------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-alpha (trunk) Severity: normal | Resolution: Keywords: | ----------------------------+----------------------------------------------- Comment (by so1o): Personally i think the current structure works much better.. if we do this.. now we will have to place the my-plugins and my-templates in that folder and upgrade will be not as straight forward.. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sat Aug 2 07:40:18 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sat Aug 2 13:17:09 2008 Subject: [Bb-trac] [bbPress] #913: get_forums hierarchical processing breaks if filters are used Message-ID: <043.d89d6cd60c77a77a926a6754a31fdfda@lists.bbpress.org> #913: get_forums hierarchical processing breaks if filters are used --------------------------+------------------------------------------------- Reporter: chrispoirier | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Back-end | Version: 0.9.1 Severity: normal | Keywords: --------------------------+------------------------------------------------- The code in bb-includes/functions.php/get_forums() that removes forums from the calculated forums list, based on $child_of, $hierarchical, or $depth processing, uses array index as a substitute for forum ID, which is not reliable if apply_filters() processing on the original list actually changes the list. Instead, I suspect the code should build a new array and copy elements based on forum ID directly. I used the following (simple, stupid, inefficient) hack to resolve a problem with the display of forums filtered by the Private Forums plugin: {{{ if ( $child_of || $hierarchical || $depth ) { $_forums = bb_get_forums_hierarchical( $child_of, $depth, $forums, true ); if ( !is_array( $_forums ) ) return false; $_forums = (array) bb_flatten_array( $_forums, $cut_branch ); $final = array(); foreach ( array_keys($_forums) as $_id ) foreach( $forums as $forum ) if( $forum->forum_id == $_id ) $final[] = $forum; $forums = $final; } }}} -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 5 14:48:51 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 5 14:49:03 2008 Subject: [Bb-trac] [bbPress] #914: Sort plugins in admin by plugin name? Message-ID: <035.418fcba39323abbe2d477941d2313e2f@lists.bbpress.org> #914: Sort plugins in admin by plugin name? ----------------------------+----------------------------------------------- Reporter: Null | Owner: Type: enhancement | Status: new Priority: low | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 0.9.0.2 Severity: normal | Keywords: ----------------------------+----------------------------------------------- I have no idea how these are sorted now, but seems logical to me to sort them by plugin name. Currently they aren't sorted at all (though it seems). When having a big pluginslist, it can get frustrated to find and (de)activate a plugin when they are not sorted. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 5 15:13:45 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 5 15:13:56 2008 Subject: [Bb-trac] [bbPress] #915: bb-plugins and my-plugins causes confusion Message-ID: <035.43b5a2af5f96bfa720e5b94b7fc6c7ca@lists.bbpress.org> #915: bb-plugins and my-plugins causes confusion -------------------------+-------------------------------------------------- Reporter: Null | Owner: Type: enhancement | Status: new Priority: low | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: 0.9.0.2 Severity: normal | Keywords: -------------------------+-------------------------------------------------- The bb-plugins and my-plugins folders causes confusion. People keep asking where to put their plugins. Lets keep things simple and put all plugins in one folder (bb-plugins). Same goes for the templates folder -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 5 16:38:44 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 5 16:38:57 2008 Subject: [Bb-trac] [bbPress] #916: restrict certain names Message-ID: <035.2fb6a9b4e7829096291a08dff82e596e@lists.bbpress.org> #916: restrict certain names ----------------------------+----------------------------------------------- Reporter: Null | Owner: Type: enhancement | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 0.9.0.2 Severity: normal | Keywords: ----------------------------+----------------------------------------------- Let the admin create a list of names that aren't allowed for to new users when they want to registrate. This way we can prefent people to registrate with names like Admin or Administator, Motherfucker, etc. This check should also be on the nicename -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 5 18:24:51 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 5 18:25:05 2008 Subject: [Bb-trac] Re: [bbPress] #916: restrict certain names In-Reply-To: <035.2fb6a9b4e7829096291a08dff82e596e@lists.bbpress.org> References: <035.2fb6a9b4e7829096291a08dff82e596e@lists.bbpress.org> Message-ID: <044.7aa7c27159eaae60177888dd23f7a3cd@lists.bbpress.org> #916: restrict certain names ----------------------------+----------------------------------------------- Reporter: Null | Owner: Type: enhancement | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 0.9.0.2 Severity: normal | Resolution: Keywords: | ----------------------------+----------------------------------------------- Comment (by _ck_): This would be done via plugin, not internally. Look at the impostercide plugin for WordPress. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 6 07:02:38 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 6 07:02:52 2008 Subject: [Bb-trac] [bbPress] #917: Those with edit_users cap should be able to change user's email Message-ID: <039.e78bae67402a92a841ce7845cd89ae76@lists.bbpress.org> #917: Those with edit_users cap should be able to change user's email ----------------------------+----------------------------------------------- Reporter: mdawaffe | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 0.9.0.2 Severity: normal | Keywords: ----------------------------+----------------------------------------------- In the past, we've been wary of letting admins change email addresses. It's not that big of a deal, is it? Let's let admins change user emails. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 6 12:08:06 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 6 16:38:33 2008 Subject: [Bb-trac] [bbPress] #918: function get_forums causes excessive db queries Message-ID: <035.322d8d8913842e4a93316423badfc39e@lists.bbpress.org> #918: function get_forums causes excessive db queries ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: normal | Keywords: ----------------------+----------------------------------------------------- I hope the new get_forums was written this way just to get it into place and will be optimized at some point? If a site has a couple dozen forums, it causes a couple dozen queries, ironically most will be empty returns if there is no meta used: {{{ foreach ( $_forums = (array) $bbdb->get_results("SELECT * FROM $bbdb->forums $where ORDER BY forum_order") as $f ) { in the loop?! -->> $f = bb_append_meta( $f, 'forum' ); <<-- $forums[(int) $f->forum_id] = $f; $forum_ids[] = (int) $f->forum_id; wp_cache_add( $f->forum_id, $f, 'bb_forum' ); wp_cache_add( $f->forum_slug, $f->forum_id, 'bb_forum_slug' ); } }}} This should be done like the topic meta where it's all appended with a single db query that is built from the id #s, then post-processed. I also concerned that the pre-load all options switch is now broken/ignored and each option is loaded individually on demand. But I am going to assume it's just something that has not been addressed yet due to limited time. bb_meta is a decent concept but please remember that mysql can only use one index for any query making bb_meta always slow since it will require full scans after the meta type is specified (that's your one index). Joins on the data may not even be able to take advantage of the indexes, unlike topicmeta or usermeta which can use it's one index to join on the ID # (bb_meta will need two pieces of info, the ID # AND the meta type, but only one index can be used). -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 6 17:19:54 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 6 17:42:39 2008 Subject: [Bb-trac] [bbPress] #919: bb_update_meta does not obey SAVEQUERIES Message-ID: <035.ee0d88bfaf7bf213ce31c8e602a3feca@lists.bbpress.org> #919: bb_update_meta does not obey SAVEQUERIES ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: normal | Keywords: ----------------------+----------------------------------------------------- For some reason I can't easily spot at the moment, bb_update_meta apparently does not save it's db transactions to the SAVEQUERIES $bbdb->queries list. Oh wait, I think I know what it is. When I do INSERT and UPDATE, I do it though $bbdb->get_results but bb_update_meta uses $bbdb->update and $bbdb->insert and even $bbdb->getrow are those calls not added to the queries list?! They should be. This means bbPress has many more "hidden" db transactions than I previously thought - not good! -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 6 17:48:54 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 6 17:49:05 2008 Subject: [Bb-trac] Re: [bbPress] #919: bb_update_meta does not obey SAVEQUERIES In-Reply-To: <035.ee0d88bfaf7bf213ce31c8e602a3feca@lists.bbpress.org> References: <035.ee0d88bfaf7bf213ce31c8e602a3feca@lists.bbpress.org> Message-ID: <044.17b52dc8eedfd1d88db0142b8ba41f14@lists.bbpress.org> #919: bb_update_meta does not obey SAVEQUERIES ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: closed Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: normal | Resolution: invalid Keywords: | ----------------------+----------------------------------------------------- Changes (by _ck_): * status: new => closed * resolution: => invalid Comment: Argh, sorry. This is not a bug in the function. It's a bug in the template in that the queries are shown before the template is finished rendering so queries are left off. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Thu Aug 7 20:13:45 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Thu Aug 7 20:13:59 2008 Subject: [Bb-trac] [bbPress] #920: Allow login with email/password Message-ID: <039.e9b4b7f4c0401c6904b66425031e734d@lists.bbpress.org> #920: Allow login with email/password ----------------------------+----------------------------------------------- Reporter: mdawaffe | Owner: Type: enhancement | Status: new Priority: normal | Milestone: 1.0 Component: Administration | Version: 1.0-alpha (trunk) Severity: normal | Keywords: ----------------------------+----------------------------------------------- Part of a global: make it easier to recover username and password movement. bbPress should let you log in via username or email address. Problems: 1. Email addresses are not unique in braches/0.9 and so may not be unique in any bbPress install. Suggestion: bail if multiple addresses match: require log in via username for those users. 2. Our error messages say: "username doesn't exist" or "password invalid" depending on the case. This is does not leak information, since usernames are easily found by other means (profile.php, for instance). If we have similar errors for logging in via email, though, we leak what email addresses are registered. Suggestion: show non-leaking errors when a user logs in with an email address. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Thu Aug 7 20:15:32 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Thu Aug 7 20:15:45 2008 Subject: [Bb-trac] Re: [bbPress] #920: Allow login with email/password In-Reply-To: <039.e9b4b7f4c0401c6904b66425031e734d@lists.bbpress.org> References: <039.e9b4b7f4c0401c6904b66425031e734d@lists.bbpress.org> Message-ID: <048.e2cdf946e1e4b02b35188d0ae3fd0775@lists.bbpress.org> #920: Allow login with email/password ----------------------------+----------------------------------------------- Reporter: mdawaffe | Owner: Type: enhancement | Status: new Priority: normal | Milestone: 1.0 Component: Administration | Version: 1.0-alpha (trunk) Severity: normal | Resolution: Keywords: | ----------------------------+----------------------------------------------- Comment (by mdawaffe): [1623] for trunk implements: Allow log in with email address if email_login setting is true; suggestion for problem 1. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Thu Aug 7 20:26:39 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Thu Aug 7 20:26:50 2008 Subject: [Bb-trac] [bbPress] #921: Easier discovery of password reset feature Message-ID: <039.e7a38f661b6187768d34aaeccb7982fa@lists.bbpress.org> #921: Easier discovery of password reset feature ----------------------------+----------------------------------------------- Reporter: mdawaffe | Owner: Type: enhancement | Status: new Priority: normal | Milestone: 1.0 Component: Administration | Version: 1.0-alpha (trunk) Severity: normal | Keywords: ----------------------------+----------------------------------------------- Part of a global: make it easier to recover username and password movement. It's really hard to figure out how to reset your password in bbPress. Instead of just clicking a link, you have to: 1. Enter your username and a password guess (or leave password blank). 2. Then click a button that will send an password reset verification email to you. It's hard to find. Suggestion: add a "Forgot your password?" link to the login form and make the password recovery button always visible. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Fri Aug 8 00:35:03 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Fri Aug 8 00:35:17 2008 Subject: [Bb-trac] Re: [bbPress] #909: request for debug_backtrace in SAVEQUERIES via db-mysql class In-Reply-To: <035.85c9d4d33314ab76f016a3375342f926@lists.bbpress.org> References: <035.85c9d4d33314ab76f016a3375342f926@lists.bbpress.org> Message-ID: <044.7835ebd8270ab94d23be7c7de224e356@lists.bbpress.org> #909: request for debug_backtrace in SAVEQUERIES via db-mysql class -------------------------+-------------------------------------------------- Reporter: _ck_ | Owner: Type: enhancement | Status: closed Priority: low | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: minor | Resolution: wontfix Keywords: | -------------------------+-------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => wontfix Comment: This is in backpress, probably won't fix for the 0.9 branch. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Fri Aug 8 00:44:14 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Fri Aug 8 00:44:27 2008 Subject: [Bb-trac] Re: [bbPress] #915: bb-plugins and my-plugins causes confusion In-Reply-To: <035.43b5a2af5f96bfa720e5b94b7fc6c7ca@lists.bbpress.org> References: <035.43b5a2af5f96bfa720e5b94b7fc6c7ca@lists.bbpress.org> Message-ID: <044.8452c9e168df49ccce5efa46dedf002b@lists.bbpress.org> #915: bb-plugins and my-plugins causes confusion -------------------------+-------------------------------------------------- Reporter: Null | Owner: Type: enhancement | Status: new Priority: low | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: 0.9.0.2 Severity: normal | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by sambauers): I think we have covered this before, and I know it's a major issue in support. Perhaps we can add these folder to the downloadable zip version without adding them to the subversion repository. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Fri Aug 8 00:45:25 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Fri Aug 8 00:45:38 2008 Subject: [Bb-trac] Re: [bbPress] #916: restrict certain names In-Reply-To: <035.2fb6a9b4e7829096291a08dff82e596e@lists.bbpress.org> References: <035.2fb6a9b4e7829096291a08dff82e596e@lists.bbpress.org> Message-ID: <044.12c8b7e439cd056d6de729bba10cc83b@lists.bbpress.org> #916: restrict certain names ----------------------------+----------------------------------------------- Reporter: Null | Owner: Type: enhancement | Status: closed Priority: normal | Milestone: Component: Administration | Version: 0.9.0.2 Severity: normal | Resolution: wontfix Keywords: | ----------------------------+----------------------------------------------- Changes (by sambauers): * status: new => closed * resolution: => wontfix * milestone: 1.0-beta & XML-RPC => Comment: I tend to agree that this should be a plugin rather than core. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 09:17:40 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 09:18:35 2008 Subject: [Bb-trac] Re: [bbPress] #922: bbPress is not inserting display names during registration In-Reply-To: <035.587b2473aa0e363042bc2c18e0d0ab78@lists.bbpress.org> References: <035.587b2473aa0e363042bc2c18e0d0ab78@lists.bbpress.org> Message-ID: <044.8eb0fa05109a5bc29fb585870724938c@lists.bbpress.org> #922: bbPress is not inserting display names during registration -------------------------+-------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: highest | Milestone: 1.0-beta & XML-RPC Component: integration | Version: 0.9.0.2 Severity: critical | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by _ck_): The problem persists in 1.0 alpha and is on line 487 -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 09:15:40 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 09:18:45 2008 Subject: [Bb-trac] [bbPress] #922: bbPress is not inserting display names during registration Message-ID: <035.587b2473aa0e363042bc2c18e0d0ab78@lists.bbpress.org> #922: bbPress is not inserting display names during registration -------------------------+-------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: highest | Milestone: 1.0-beta & XML-RPC Component: integration | Version: 0.9.0.2 Severity: critical | Keywords: -------------------------+-------------------------------------------------- I thought this was fixed for 0.9.0.2 but apparently not. When integrated, bbPress fails to insert a display name so WordPress shows the user as "anonymous" even though they have an ID and a user_login (this could be considered WordPress bug too but bbPress made the problem, it should fix it...) Perhaps there should also be a check on upgrade/reinstall to scan the user table for users without display names and create them to fix forums with this problem extensively. props ragekage: http://bbpress.org/forums/topic/why-is-integration-so- troublesom#post-17389 {{{ pluggable.php in bb-includes Line 502 $bbdb->insert( $bbdb->users,compact( 'user_login', 'user_pass', 'user_nicename', 'user_email', 'user_url', 'user_registered' )); Replace with // bbPress / Wordpress bug fix added display name to wordpress $display_name = $user_login; $bbdb->insert( $bbdb->users,compact( 'user_login', 'user_pass', 'user_nicename', 'user_email', 'user_url', 'user_registered', 'display_name' )); }}} -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 09:39:20 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 09:40:28 2008 Subject: [Bb-trac] Re: [bbPress] #922: bbPress is not inserting display names during registration In-Reply-To: <035.587b2473aa0e363042bc2c18e0d0ab78@lists.bbpress.org> References: <035.587b2473aa0e363042bc2c18e0d0ab78@lists.bbpress.org> Message-ID: <044.0154e4120c4048db02b2946989730cb6@lists.bbpress.org> #922: bbPress is not inserting display names during registration -------------------------+-------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: highest | Milestone: 1.0-beta & XML-RPC Component: integration | Version: 0.9.0.2 Severity: critical | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by _ck_): Mini-plugin to repair user table by copying user_login to display_name if display_name is blank: {{{ function fix_anonymous() {global $bbdb; $bbdb->query("UPDATE $bbdb->users SET display_name=user_login WHERE display_name='' "); } add_action('bb_init','fix_anonymous'); }}} However this is a horrendous waste of database space. It's indeed a bug on the WordPress side that when the display_name is empty to display "anonymous" regardless if there is a valid user id # and user_login. It's meant to deal with anonymous commenters that have no account but it fails to anticipate a registered user with no display name. I am also filing a WordPress ticket on this. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 10:31:18 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 10:31:42 2008 Subject: [Bb-trac] Re: [bbPress] #922: bbPress is not inserting display names during registration In-Reply-To: <035.587b2473aa0e363042bc2c18e0d0ab78@lists.bbpress.org> References: <035.587b2473aa0e363042bc2c18e0d0ab78@lists.bbpress.org> Message-ID: <044.32f71de15424983fd9983a216723567a@lists.bbpress.org> #922: bbPress is not inserting display names during registration -------------------------+-------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: highest | Milestone: 1.0-beta & XML-RPC Component: integration | Version: 0.9.0.2 Severity: critical | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by _ck_): I've now posted a corresponding WordPress Trac ticket with fix: http://trac.wordpress.org/ticket/7494 -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 10:45:11 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 10:47:12 2008 Subject: [Bb-trac] Re: [bbPress] #922: bbPress is not inserting display names during registration In-Reply-To: <035.587b2473aa0e363042bc2c18e0d0ab78@lists.bbpress.org> References: <035.587b2473aa0e363042bc2c18e0d0ab78@lists.bbpress.org> Message-ID: <044.e20821f048f0089190570e0d1a433808@lists.bbpress.org> #922: bbPress is not inserting display names during registration -------------------------+-------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: highest | Milestone: 1.0-beta & XML-RPC Component: integration | Version: 0.9.0.2 Severity: critical | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by _ck_): This plugin is meant as a temporarily workaround - it will replace "anonymous" with the user login. It is meant to be installed on the WordPress side: {{{ comment_author) && !empty($comment->user_id)) {$user=get_userdata($comment->user_id); $author=$user->user_login;} return $author; } add_filter('get_comment_author', 'no_anonymous_members'); if ( !function_exists('get_userdata') ) : function get_userdata( $user_id ) { global $wpdb; $user_id = absint($user_id); if ( $user_id == 0 ) return false; $user = wp_cache_get($user_id, 'users'); if ( $user ) if (empty($user->display_name)) {$user->display_name=$user->user_login;} return $user; if ( !$user = $wpdb->get_row($wpdb->prepare("SELECT * FROM $wpdb->users WHERE ID = %d LIMIT 1", $user_id)) ) return false; _fill_user($user); if (empty($user->display_name)) {$user->display_name=$user->user_login;} return $user; } endif; ?> }}} The real answer of course is to insert the user_login when the comment is posted however I cannot find a suitable hook in WordPress's `comment- template.php` so I am doing it by completely replacing the get_userdata function in `pluggable.php` -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 19:20:56 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 19:21:10 2008 Subject: [Bb-trac] Re: [bbPress] #887: forum_id not updated on each topic's posts when topic is moved to another forum In-Reply-To: <035.e37235010b648d85d7560731f0b3b636@lists.bbpress.org> References: <035.e37235010b648d85d7560731f0b3b636@lists.bbpress.org> Message-ID: <044.923e6fe281162530529373779cb8f6b8@lists.bbpress.org> #887: forum_id not updated on each topic's posts when topic is moved to another forum ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: closed Priority: high | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: major | Resolution: fixed Keywords: | ----------------------+----------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => fixed Comment: I bet this was fixed by [1627]. Reopen if not. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 19:41:17 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 19:41:49 2008 Subject: [Bb-trac] Re: [bbPress] #876: forum_stickies query is not very useful on large sites In-Reply-To: <039.971987256d442283f26659564ffc7e3d@lists.bbpress.org> References: <039.971987256d442283f26659564ffc7e3d@lists.bbpress.org> Message-ID: <048.ac22d656579f3b32c29897000bdbe379@lists.bbpress.org> #876: forum_stickies query is not very useful on large sites ----------------------+----------------------------------------------------- Reporter: mdawaffe | Owner: Type: defect | Status: closed Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: 0.9.0.1 Severity: normal | Resolution: fixed Keywords: mysql | ----------------------+----------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => fixed Comment: [1638] -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 20:08:13 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 20:08:25 2008 Subject: [Bb-trac] Re: [bbPress] #905: can't delete first forum (forum id #1) In-Reply-To: <035.18a65a7c43408f2454e6dfcf81886e7e@lists.bbpress.org> References: <035.18a65a7c43408f2454e6dfcf81886e7e@lists.bbpress.org> Message-ID: <044.ac5098e2843f6f194c7689bba3b7ce7c@lists.bbpress.org> #905: can't delete first forum (forum id #1) ----------------------------+----------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: high | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: Severity: major | Resolution: Keywords: | ----------------------------+----------------------------------------------- Comment (by mdawaffe): You can delete the first forum in trunk as long as there is at least one other forum. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 20:29:12 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 20:29:26 2008 Subject: [Bb-trac] Re: [bbPress] #922: bbPress is not inserting display names during registration In-Reply-To: <035.587b2473aa0e363042bc2c18e0d0ab78@lists.bbpress.org> References: <035.587b2473aa0e363042bc2c18e0d0ab78@lists.bbpress.org> Message-ID: <044.ea9d9d1272e19a6f402abdd52743c30e@lists.bbpress.org> #922: bbPress is not inserting display names during registration -------------------------+-------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: closed Priority: highest | Milestone: 1.0-beta & XML-RPC Component: integration | Version: 0.9.0.2 Severity: critical | Resolution: worksforme Keywords: | -------------------------+-------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => worksforme Comment: Replying to [comment:1 _ck_]: > The problem persists in 1.0 alpha and is on line 487 This is not a problem in trunk. $wp_users_object->new_user() handles this. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 20:38:41 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 20:38:57 2008 Subject: [Bb-trac] Re: [bbPress] #910: Incorrect Doctype for the default skin In-Reply-To: <038.9735f65b26aafb7ab9519d2d13ee9566@lists.bbpress.org> References: <038.9735f65b26aafb7ab9519d2d13ee9566@lists.bbpress.org> Message-ID: <047.9890e9688293d87157f623f378a8f209@lists.bbpress.org> #910: Incorrect Doctype for the default skin -----------------------+---------------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-beta (trunk) Severity: normal | Resolution: Keywords: | -----------------------+---------------------------------------------------- Comment (by mdawaffe): Why is 1.1 bad? -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 20:39:37 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 20:39:50 2008 Subject: [Bb-trac] Re: [bbPress] #911: Create a bb-content with templates, plugins and languages, like in Wordpress In-Reply-To: <038.46c20226d4b17bf336ee383a09789197@lists.bbpress.org> References: <038.46c20226d4b17bf336ee383a09789197@lists.bbpress.org> Message-ID: <047.e10b847232f71cc24c2d027a9d7b81df@lists.bbpress.org> #911: Create a bb-content with templates, plugins and languages, like in Wordpress ----------------------------+----------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: closed Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-beta (trunk) Severity: normal | Resolution: invalid Keywords: | ----------------------------+----------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => invalid -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 21:07:12 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 21:07:24 2008 Subject: [Bb-trac] Re: [bbPress] #914: Sort plugins in admin by plugin name? In-Reply-To: <035.418fcba39323abbe2d477941d2313e2f@lists.bbpress.org> References: <035.418fcba39323abbe2d477941d2313e2f@lists.bbpress.org> Message-ID: <044.ce6f9fa744aa1c8963b1db0703554546@lists.bbpress.org> #914: Sort plugins in admin by plugin name? ----------------------------+----------------------------------------------- Reporter: Null | Owner: Type: enhancement | Status: reopened Priority: low | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 0.9.0.2 Severity: normal | Resolution: Keywords: | ----------------------------+----------------------------------------------- Changes (by csseur3): * status: closed => reopened * resolution: fixed => Comment: i have this error: Warning: file(4) [function.file]: failed to open stream: No such file or directory in /home/bbpress/bb-admin/admin-functions.php on line 989 Warning: implode() [function.implode]: Invalid arguments passed in /home/bbpress/bb-admin/admin-functions.php on line 989 Warning: Cannot modify header information - headers already sent by (output started at /home/bbpress/bb-admin/admin-functions.php:989) in /home/bbpress/bb-includes/pluggable.php on line 213 Warning: Cannot modify header information - headers already sent by (output started at /home/bbpress/bb-admin/admin-functions.php:989) in /home/bbpress/bb-includes/pluggable.php on line 213 -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 21:33:01 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 21:33:14 2008 Subject: [Bb-trac] Re: [bbPress] #903: using duplicate email fails but gives no message on registration In-Reply-To: <035.1232239e9d5ffa11d3cde54aa24e3def@lists.bbpress.org> References: <035.1232239e9d5ffa11d3cde54aa24e3def@lists.bbpress.org> Message-ID: <044.4f87e229c411695d33644b919f202b37@lists.bbpress.org> #903: using duplicate email fails but gives no message on registration --------------------------+------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: low | Milestone: 1.0-beta & XML-RPC Component: Registration | Version: 1.0-beta (trunk) Severity: minor | Resolution: Keywords: | --------------------------+------------------------------------------------- Comment (by mdawaffe): [1642] leaks email info. Is that ok? -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 21:38:41 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 21:38:53 2008 Subject: [Bb-trac] Re: [bbPress] #914: Sort plugins in admin by plugin name? In-Reply-To: <035.418fcba39323abbe2d477941d2313e2f@lists.bbpress.org> References: <035.418fcba39323abbe2d477941d2313e2f@lists.bbpress.org> Message-ID: <044.76faafec861efed8422851c8f3c6fefd@lists.bbpress.org> #914: Sort plugins in admin by plugin name? ----------------------------+----------------------------------------------- Reporter: Null | Owner: Type: enhancement | Status: closed Priority: low | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 0.9.0.2 Severity: normal | Resolution: fixed Keywords: | ----------------------------+----------------------------------------------- Changes (by mdawaffe): * status: reopened => closed * resolution: => fixed Comment: csseur3: That looks like an unrelated bug. Please open a new ticket. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 21:43:14 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 21:43:24 2008 Subject: [Bb-trac] Re: [bbPress] #907: sticky processing doubles db queries and reduces mysql performance In-Reply-To: <035.1c7588d26db24c858c2a2bdf6060c2b6@lists.bbpress.org> References: <035.1c7588d26db24c858c2a2bdf6060c2b6@lists.bbpress.org> Message-ID: <044.25158c9e20490d949bb8c4bd62df051f@lists.bbpress.org> #907: sticky processing doubles db queries and reduces mysql performance ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: closed Priority: low | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: minor | Resolution: wontfix Keywords: | ----------------------+----------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => wontfix Comment: The limits make this difficult. If we really wanted to, we could try combining the 2nd and 3rd queries, but we'd end up with ugly code and a few extra loops. Those two queries are really fast, though, so it doesn't seem worth the complexity. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 11 23:52:21 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 11 23:52:35 2008 Subject: [Bb-trac] Re: [bbPress] #899: blocked user may not work anymore in 0.9.x ? In-Reply-To: <035.791ddf8be0c167abcb0c979d4368fefa@lists.bbpress.org> References: <035.791ddf8be0c167abcb0c979d4368fefa@lists.bbpress.org> Message-ID: <044.154a7490b8e93fe0343a32a224201b8c@lists.bbpress.org> #899: blocked user may not work anymore in 0.9.x ? ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: closed Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: normal | Resolution: fixed Keywords: | ----------------------+----------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => fixed Comment: Fixed in [BP112] -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 12 00:08:40 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 12 00:08:52 2008 Subject: [Bb-trac] Re: [bbPress] #913: get_forums hierarchical processing breaks if filters are used In-Reply-To: <043.d89d6cd60c77a77a926a6754a31fdfda@lists.bbpress.org> References: <043.d89d6cd60c77a77a926a6754a31fdfda@lists.bbpress.org> Message-ID: <052.a4bd98184eeb41aff08b3431d945f018@lists.bbpress.org> #913: get_forums hierarchical processing breaks if filters are used --------------------------+------------------------------------------------- Reporter: chrispoirier | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: Back-end | Version: 0.9.1 Severity: normal | Resolution: invalid Keywords: | --------------------------+------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => invalid Comment: The array is indexed by forum_id already. The problem you mentioned is specific to the Private Forums plugin, and has been fixed in that plugin. I've pasted below what the old code was and commented where the fix should have gone. Aditya (the author) fixed it a different way by using a different set of filters to accomplish the same task. {{{ apply_filters( 'get_forums', 'private_forums_filter_forums' ); function private_forums_filter_forums($forums) { $new_forums = array(); if ($forums) { $private_forums = private_forums_custom_get_options('private_forums'); foreach($forums as $forum) { if(!array_key_exists($forum->forum_id,$private_forums)) { $new_forums[] = $forum; // The above line should be replaced by the below line. // $new_forums[$forum->forum_id] = $forum; } } return $new_forums ; } return $forums; } }}} -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 12 00:15:05 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 12 00:15:22 2008 Subject: [Bb-trac] Re: [bbPress] #918: function get_forums causes excessive db queries In-Reply-To: <035.322d8d8913842e4a93316423badfc39e@lists.bbpress.org> References: <035.322d8d8913842e4a93316423badfc39e@lists.bbpress.org> Message-ID: <044.5e04b441011049eb18b360c52f28b754@lists.bbpress.org> #918: function get_forums causes excessive db queries ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: normal | Resolution: Keywords: | ----------------------+----------------------------------------------------- Comment (by mdawaffe): MySQL can only use one index at a time, but that index may span multiple columns. {{{ KEY `object_type__object_id__meta_key` (`object_type`, `object_id`, `meta_key`) }}} that index means we'll never do a full table scan if we look at, say, forum meta for forum_id = 1. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 12 01:12:42 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 12 01:13:02 2008 Subject: [Bb-trac] Re: [bbPress] #578: Auto filter double posts In-Reply-To: <035.bcad1b1855269649010488b99e3b4cc5@lists.bbpress.org> References: <035.bcad1b1855269649010488b99e3b4cc5@lists.bbpress.org> Message-ID: <044.55f4dcbfff2c5108e458c12326e94b8c@lists.bbpress.org> #578: Auto filter double posts -------------------------+-------------------------------------------------- Reporter: Null | Owner: Type: defect | Status: closed Priority: normal | Milestone: 1.0 Component: Back-end | Version: 0.8 Severity: minor | Resolution: wontfix Keywords: needs-patch | -------------------------+-------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => wontfix Comment: Agreed - people who have throttle turned off can also typically delete any double post as well. Let's look at disabling the post button via JS when we re-add AJAX posting. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 12 01:15:02 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 12 01:15:14 2008 Subject: [Bb-trac] Re: [bbPress] #568: Abstract $bb_current_user phase 2 In-Reply-To: <039.22d07a85d4f3d63bfbe57b07cce715b2@lists.bbpress.org> References: <039.22d07a85d4f3d63bfbe57b07cce715b2@lists.bbpress.org> Message-ID: <048.fac7e5119aade8ab73197f699512c1cd@lists.bbpress.org> #568: Abstract $bb_current_user phase 2 -------------------------+-------------------------------------------------- Reporter: mdawaffe | Owner: Type: enhancement | Status: closed Priority: normal | Milestone: Component: Back-end | Version: 0.7.5 Severity: normal | Resolution: worksforme Keywords: | -------------------------+-------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => worksforme * milestone: 1.0 => Comment: We do a pretty good job of this already. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 12 01:18:43 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 12 01:18:55 2008 Subject: [Bb-trac] Re: [bbPress] #722: Virtual areas in root In-Reply-To: <036.fd146829fa650609b183bfe20da9c6b4@lists.bbpress.org> References: <036.fd146829fa650609b183bfe20da9c6b4@lists.bbpress.org> Message-ID: <045.94882247680c747f0628b86761bd1c6e@lists.bbpress.org> #722: Virtual areas in root -------------------------+-------------------------------------------------- Reporter: fel64 | Owner: Type: enhancement | Status: closed Priority: normal | Milestone: Component: Front-end | Version: 0.8.2.1 Severity: normal | Resolution: duplicate Keywords: | -------------------------+-------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => duplicate * milestone: 1.0 => Comment: #882 -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 12 01:09:24 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 12 01:47:48 2008 Subject: [Bb-trac] Re: [bbPress] #452: Support UTF-8 user names In-Reply-To: <036.7cc215ca1f3c7560b05330f658808ae2@lists.bbpress.org> References: <036.7cc215ca1f3c7560b05330f658808ae2@lists.bbpress.org> Message-ID: <045.d556038721138bb4aff144fd521778df@lists.bbpress.org> #452: Support UTF-8 user names -------------------------+-------------------------------------------------- Reporter: Sewar | Owner: Type: enhancement | Status: closed Priority: highest | Milestone: Component: i18n/l10n | Version: 0.7.2 Severity: normal | Resolution: wontfix Keywords: UTF-8 | -------------------------+-------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => wontfix * milestone: 1.0 => Comment: Let's try doing stuff with display_name and nicename. WP has had limited username characters for forever with basically no complaints. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 12 11:02:30 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 12 11:02:45 2008 Subject: [Bb-trac] [bbPress] #923: function bb_related_tags would be more useful if it accepted an array Message-ID: <035.1a75ccd9a7ccfdaead2b171bec2c91b2@lists.bbpress.org> #923: function bb_related_tags would be more useful if it accepted an array -------------------------+-------------------------------------------------- Reporter: _ck_ | Owner: Type: enhancement | Status: new Priority: low | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: minor | Keywords: -------------------------+-------------------------------------------------- Without too much work, I think bb_related_tags could be made to accept an array of tags, looping to see if each one is numeric or string, and build an array of $_tags Then instead of checking `tag_id = %d` you'd check `tag_id IN ($list_of_tag_numbers)` This would reduce the queries to just one, regardless of the number of tags on a topic. Such a function could easily return a mini related heat map for any topic's collection of tags, instead of one by one. Currently bb_related_tags is not used at ALL, in ANY template that I can find. It's been dormant, let's use it. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 12 11:11:35 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 12 11:11:48 2008 Subject: [Bb-trac] Re: [bbPress] #923: function bb_related_tags would be more useful if it accepted an array In-Reply-To: <035.1a75ccd9a7ccfdaead2b171bec2c91b2@lists.bbpress.org> References: <035.1a75ccd9a7ccfdaead2b171bec2c91b2@lists.bbpress.org> Message-ID: <044.ecc444eca01fd3da8b22a970cc994771@lists.bbpress.org> #923: function bb_related_tags would be more useful if it accepted an array -------------------------+-------------------------------------------------- Reporter: _ck_ | Owner: Type: enhancement | Status: new Priority: low | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: minor | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by _ck_): Hey why isn't it at least attached to the search function? A topic may be tagged with a word that doesn't appear in the text. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 12 13:31:56 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 12 13:32:45 2008 Subject: [Bb-trac] [bbPress] #924: Bug with admin-function and pluggable.php Message-ID: <038.4dc6e203f2ae5eed4e6d8fb952d94fbf@lists.bbpress.org> #924: Bug with admin-function and pluggable.php ----------------------------+----------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-beta (trunk) Severity: normal | Keywords: ----------------------------+----------------------------------------------- in the actual trunk, there is a bug with the new plugin sort. When i want to activate a plugin, i have this: Warning: file(4) [function.file]: failed to open stream: No such file or directory in /home/bbpress/bb-admin/admin-functions.php on line 989 Warning: implode() [function.implode]: Invalid arguments passed in /home/bbpress/bb-admin/admin-functions.php on line 989 Warning: Cannot modify header information - headers already sent by (output started at /home/bbpress/bb-admin/admin-functions.php:989) in /home/bbpress/bb-includes/pluggable.php on line 213 Warning: Cannot modify header information - headers already sent by (output started at /home/bbpress/bb-admin/admin-functions.php:989) in /home/bbpress/bb-includes/pluggable.php on line 213 bye, -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 12 17:20:13 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 12 17:20:29 2008 Subject: [Bb-trac] Re: [bbPress] #924: Bug with admin-function and pluggable.php In-Reply-To: <038.4dc6e203f2ae5eed4e6d8fb952d94fbf@lists.bbpress.org> References: <038.4dc6e203f2ae5eed4e6d8fb952d94fbf@lists.bbpress.org> Message-ID: <047.75612cb8ff627cdb56b748cdba0cb752@lists.bbpress.org> #924: Bug with admin-function and pluggable.php ----------------------------+----------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: Administration | Version: 1.0-beta (trunk) Severity: normal | Resolution: invalid Keywords: | ----------------------------+----------------------------------------------- Changes (by sambauers): * status: new => closed * resolution: => invalid * milestone: 1.0-beta & XML-RPC => Comment: The last two errors are just because the error is being echoed to output. Line 989 of admin-functions.php has no call to file() or implode() in trunk. Make sure you are right up to date with your trunk and then reopen the ticket with the correct line numbers. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 12 20:43:18 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 12 20:43:32 2008 Subject: [Bb-trac] Re: [bbPress] #910: Incorrect Doctype for the default skin In-Reply-To: <038.9735f65b26aafb7ab9519d2d13ee9566@lists.bbpress.org> References: <038.9735f65b26aafb7ab9519d2d13ee9566@lists.bbpress.org> Message-ID: <047.87df5ff73e9a64d5c84f7a4edbcfa0a9@lists.bbpress.org> #910: Incorrect Doctype for the default skin -----------------------+---------------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: closed Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-beta (trunk) Severity: normal | Resolution: fixed Keywords: | -----------------------+---------------------------------------------------- Changes (by csseur3): * status: new => closed * resolution: => fixed Comment: the theme with the new 1.0 alpha is valid :) -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 12 20:49:38 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 12 20:49:52 2008 Subject: [Bb-trac] Re: [bbPress] #924: Bug with admin-function and pluggable.php In-Reply-To: <038.4dc6e203f2ae5eed4e6d8fb952d94fbf@lists.bbpress.org> References: <038.4dc6e203f2ae5eed4e6d8fb952d94fbf@lists.bbpress.org> Message-ID: <047.367e3b4e2deeb3325f82e94c20e8cc31@lists.bbpress.org> #924: Bug with admin-function and pluggable.php ----------------------------+----------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: reopened Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-beta (trunk) Severity: normal | Resolution: Keywords: | ----------------------------+----------------------------------------------- Changes (by csseur3): * status: closed => reopened * resolution: invalid => * milestone: => 1.0-beta & XML-RPC Comment: yes, now it's the 990 line, and i have this: 990 $plugin_data = implode('', file($plugin_file)); 991 if ( !preg_match("|Plugin Name:(.*)|i", $plugin_data, $plugin_name) ) i think he was a really bug, i can't active a plugin with the real last trunk. bye -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 13 02:25:59 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 13 02:26:12 2008 Subject: [Bb-trac] [bbPress] #925: Can't delete topics and posts Message-ID: <039.cc3b55b79de9366a9daf673dfab88d10@lists.bbpress.org> #925: Can't delete topics and posts ----------------------------+----------------------------------------------- Reporter: wiseacre | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-alpha-1 Severity: normal | Keywords: ----------------------------+----------------------------------------------- I Alpha 1 and rev 1648 too I 1 Create some new topic 2 Post in some topic 3 Delete one post 4 Delete some entire topic 5 Go to Manage/Topics 6 All deleted topics and posts are here OK, that's good feature. But I (the good old key master) can't remove deleted topics and posts from the database. I am using FF 3.0.1 and kUbuntu 8.04. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 13 02:40:55 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 13 02:41:08 2008 Subject: [Bb-trac] Re: [bbPress] #925: Can't delete topics and posts In-Reply-To: <039.cc3b55b79de9366a9daf673dfab88d10@lists.bbpress.org> References: <039.cc3b55b79de9366a9daf673dfab88d10@lists.bbpress.org> Message-ID: <048.1c3d58fd356dfb87ff6e0d4482bbafea@lists.bbpress.org> #925: Can't delete topics and posts ----------------------------+----------------------------------------------- Reporter: wiseacre | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-alpha-1 Severity: normal | Resolution: Keywords: | ----------------------------+----------------------------------------------- Comment (by wiseacre): I forgot (5:38 AM for me) PHP 4.4.8 and 5.0 with .htaccess mysql Ver 14.7 Distrib 4.1.22, ... -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 13 13:47:27 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 13 13:52:28 2008 Subject: [Bb-trac] [bbPress] #926: Plugins activated, but not the same green color in the list of plugins! Message-ID: <038.5e271ed6f162c9cbac076f5aee443e34@lists.bbpress.org> #926: Plugins activated, but not the same green color in the list of plugins! ----------------------------+----------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-beta (trunk) Severity: normal | Keywords: ----------------------------+----------------------------------------------- Hello, with the new trunk, in the plugins list, plugins with the gray background- color (when they are not activated), are not green when are activated! see my capture: [http://img175.imageshack.us/my.php?image=capture3qd7.png] -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 13 14:04:06 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 13 14:27:56 2008 Subject: [Bb-trac] Re: [bbPress] #926: Plugins activated, but not the same green color in the list of plugins! In-Reply-To: <038.5e271ed6f162c9cbac076f5aee443e34@lists.bbpress.org> References: <038.5e271ed6f162c9cbac076f5aee443e34@lists.bbpress.org> Message-ID: <047.e1e80426963a5a595de114d2b32e8d55@lists.bbpress.org> #926: Plugins activated, but not the same green color in the list of plugins! ----------------------------+----------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: reopened Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-beta (trunk) Severity: normal | Resolution: Keywords: | ----------------------------+----------------------------------------------- Changes (by csseur3): * status: closed => reopened * resolution: fixed => Comment: hey sam, the bug is always here! change that: .active { background-color: rgb(200, 250, 200) } for that: .active { background-color: rgb(200, 250, 200); } the required " ; " at the end fixed the css bug :p -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 13 18:18:37 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 13 18:19:28 2008 Subject: [Bb-trac] Re: [bbPress] #924: Bug with admin-function and pluggable.php In-Reply-To: <038.4dc6e203f2ae5eed4e6d8fb952d94fbf@lists.bbpress.org> References: <038.4dc6e203f2ae5eed4e6d8fb952d94fbf@lists.bbpress.org> Message-ID: <047.a8517b1480482d061b34a834d254f014@lists.bbpress.org> #924: Bug with admin-function and pluggable.php ----------------------------+----------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: closed Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-beta (trunk) Severity: normal | Resolution: fixed Keywords: | ----------------------------+----------------------------------------------- Comment (by mdawaffe): Ah ha! Nice work you two :) -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Fri Aug 15 15:20:44 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Fri Aug 15 15:20:56 2008 Subject: [Bb-trac] [bbPress] #927: logout redirects to blank screen in Opera 9.x Message-ID: <035.7b6777e9a77c6160019e903731e98c26@lists.bbpress.org> #927: logout redirects to blank screen in Opera 9.x ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: 0.9.0.2 Severity: normal | Keywords: ----------------------+----------------------------------------------------- Logout on any version of Opera in both bbPress 0.9 and the trunk redirects the user to a blank screen. (note I block referrers like many users do these days so it might be related to that) This does not happen in Firefox, so it's Opera specific but a bug nevertheless. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Fri Aug 15 18:30:39 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Fri Aug 15 18:30:54 2008 Subject: [Bb-trac] [bbPress] #928: validate_file() function in bbPress 1.0 alpha has problems on WinBlows systems Message-ID: <039.110665cdb66b2fa1e38f34e01a314602@lists.bbpress.org> #928: validate_file() function in bbPress 1.0 alpha has problems on WinBlows systems ----------------------------+----------------------------------------------- Reporter: zappoman | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Administration | Version: 1.0-alpha-1 Severity: normal | Keywords: ----------------------------+----------------------------------------------- line: 962 of wp-functions.php if (':' == substr( $file, 1, 1 )) This will return "2" which means the file is not valid (according to the comments)... but of course on some OSes like WinBlows... this is still valid. bbPress only seems to use this in loading plugins... but of course needs to be addressed for bbPress to work on Windows. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sat Aug 16 02:01:05 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sat Aug 16 02:01:17 2008 Subject: [Bb-trac] [bbPress] #929: Everything works fine on a localhost install, but when I try install on my dreamhost account... Message-ID: <043.d6ef606a2332b7387271db85240245a0@lists.bbpress.org> #929: Everything works fine on a localhost install, but when I try install on my dreamhost account... ----------------------------------+----------------------------------------- Reporter: joelteixeira | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Installation/Upgrade | Version: 1.0-alpha-1 Severity: normal | Keywords: install, error, call-time, dreamhost ----------------------------------+----------------------------------------- I get the following error: ---- Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /bb- includes/backpress/functions.core.php on line 499 ---- The message stays on the top of page, above header, seems that I can use everything but the message stays there. $ svn info Path: URL: http://svn.automattic.com/bbpress/trunk Repository Root: http://svn.automattic.com/bbpress Repository UUID: 9866e705-20ec-0310-96e7-cbb4277adcfb Revision: 1651 Node Kind: directory Schedule: normal Last Changed Author: sambauers Last Changed Rev: 1651 Last Changed Date: 2008-08-13 12:13:00 -0700 (Wed, 13 Aug 2008) -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sat Aug 16 03:45:27 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sat Aug 16 03:45:45 2008 Subject: [Bb-trac] [bbPress] #930: tags import/upgrade not working Message-ID: <039.fc0d49bc4008805038f846624e60feba@lists.bbpress.org> #930: tags import/upgrade not working ----------------------------+----------------------------------------------- Reporter: zappoman | Owner: Type: defect | Status: new Priority: high | Milestone: Component: Administration | Version: 1.0-beta (trunk) Severity: major | Keywords: tags upgrade taxonomy ----------------------------+----------------------------------------------- When upgrading to 1.0-alpha the system attempts to convert old style tags into the new term_taxonomy structure. This appears to fail due to a required "description" column, that is not set in the import process. This appears to be an issue in both alpha and the current trunk. Details: The function function bb_upgrade_1080() around line 881 of upgrade-functions.php has the following code... {{{ $bbdb->insert( $bbdb->term_taxonomy, array( 'term_id' => $term_id, 'taxonomy' => 'bb_topic_tag' ) ); }}} This insert will fail be cause bb_term_taxonomy is created with a description field that is NOT NULL. As indicated by the code around line 101 of upgrade-schema.php {{{ // term_taxonomy $bb_queries['term_taxonomy'] = "CREATE TABLE IF NOT EXISTS `$bbdb->term_taxonomy` ( `term_taxonomy_id` bigint(20) NOT NULL auto_increment, `term_id` bigint(20) NOT NULL default 0, `taxonomy` varchar(32) NOT NULL default '', `description` longtext NOT NULL, `parent` bigint(20) NOT NULL default 0, `count` bigint(20) NOT NULL default 0, PRIMARY KEY (`term_taxonomy_id`), UNIQUE KEY `term_id_taxonomy` (`term_id`, `taxonomy`) );"; }}} -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sat Aug 16 04:01:41 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sat Aug 16 04:01:53 2008 Subject: [Bb-trac] [bbPress] #931: Call-time pass-by-reference has been deprecated - argument passed by value; -- in backpress_convert_object() Message-ID: <039.763548eadb57781eb67f48c1bc10f20e@lists.bbpress.org> #931: Call-time pass-by-reference has been deprecated - argument passed by value; -- in backpress_convert_object() ----------------------------+----------------------------------------------- Reporter: zappoman | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Administration | Version: 1.0-beta (trunk) Severity: normal | Keywords: ----------------------------+----------------------------------------------- The function backpress_convert_object() causes the following PHP runtime error... Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in C:\var\konamoxt\living10x\bbpress-dev-trunk\bb- includes\backpress\functions.core.php on line 499 -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sat Aug 16 04:02:54 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sat Aug 16 04:03:06 2008 Subject: [Bb-trac] Re: [bbPress] #931: Call-time pass-by-reference has been deprecated - argument passed by value; -- in backpress_convert_object() In-Reply-To: <039.763548eadb57781eb67f48c1bc10f20e@lists.bbpress.org> References: <039.763548eadb57781eb67f48c1bc10f20e@lists.bbpress.org> Message-ID: <048.1499ad296036344c9fcc80c24407028d@lists.bbpress.org> #931: Call-time pass-by-reference has been deprecated - argument passed by value; -- in backpress_convert_object() ----------------------------+----------------------------------------------- Reporter: zappoman | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: Administration | Version: 1.0-beta (trunk) Severity: normal | Resolution: duplicate Keywords: | ----------------------------+----------------------------------------------- Changes (by zappoman): * status: new => closed * resolution: => duplicate -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sat Aug 16 04:12:34 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sat Aug 16 04:12:51 2008 Subject: [Bb-trac] [bbPress] #932: tag pages broken -- get_tagged_topics() returns empty array Message-ID: <039.f7214ea1996264192c9498bb07e44607@lists.bbpress.org> #932: tag pages broken -- get_tagged_topics() returns empty array -----------------------+---------------------------------------------------- Reporter: zappoman | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Front-end | Version: 1.0-beta (trunk) Severity: major | Keywords: tags -----------------------+---------------------------------------------------- Tag URLS don't list topics that are in the tags. Tracing through it shows that get_tagged_topics() returns empty array. This makes tag urls pretty much broken. Since the BB_Query() appears to be a massive rewrite between 0.9.x and 1.0 I assume this is an issue in the new code. But I leave it to the experts. :) -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sat Aug 16 20:04:43 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sat Aug 16 20:04:55 2008 Subject: [Bb-trac] Re: [bbPress] #929: Call-time pass-by-reference has been deprecated; [functions.core.php] In-Reply-To: <043.d6ef606a2332b7387271db85240245a0@lists.bbpress.org> References: <043.d6ef606a2332b7387271db85240245a0@lists.bbpress.org> Message-ID: <052.b60fcdbd564cc1044698fdebafc42e60@lists.bbpress.org> #929: Call-time pass-by-reference has been deprecated; [functions.core.php] --------------------------------------------------+------------------------- Reporter: joelteixeira | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Installation/Upgrade | Version: 1.0-alpha-1 Severity: normal | Resolution: Keywords: install, error, call-time, dreamhost | --------------------------------------------------+------------------------- Changes (by joelteixeira): * summary: Everything works fine on a localhost install, but when I try install on my dreamhost account... => Call-time pass-by-reference has been deprecated; [functions.core.php] Comment: Guys, this is a diff between functions.core.php from a 1.0-alpha (woking) and from a svn trunk install where i get the error. Changing only this file eliminates the error. {{{ 494a495,507 > > function backpress_convert_object( &$object, $output ) { > if ( is_array( $object ) ) { > foreach ( array_keys( $object ) as $key ) > backpress_convert_object( &$object[$key], $output ); > } else { > switch ( $output ) { > case OBJECT : break; > case ARRAY_A : $object = get_object_vars($object); break; > case ARRAY_N : $object = array_values(get_object_vars($object)); break; > } > } > } }}} -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sat Aug 16 23:02:21 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sat Aug 16 23:02:34 2008 Subject: [Bb-trac] [bbPress] #933: Problem with register form: "1" is show in the first input Message-ID: <038.00891ebd7255a4031eee52028535f1b5@lists.bbpress.org> #933: Problem with register form: "1" is show in the first input --------------------------+------------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Registration | Version: 1.0-beta (trunk) Severity: normal | Keywords: --------------------------+------------------------------------------------- Hello, in the register page, we have this: {{{ }}} so, in my browser, i see that: {{{ }}} why "1" is displayed? i use the trunk. bye -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sun Aug 17 09:40:22 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sun Aug 17 09:40:38 2008 Subject: [Bb-trac] Re: [bbPress] #932: tag pages broken -- get_tagged_topics() returns empty array In-Reply-To: <039.f7214ea1996264192c9498bb07e44607@lists.bbpress.org> References: <039.f7214ea1996264192c9498bb07e44607@lists.bbpress.org> Message-ID: <048.a039f4ad86f8915bfaf272802db539b4@lists.bbpress.org> #932: tag pages broken -- get_tagged_topics() returns empty array --------------------------+------------------------------------------------- Reporter: zappoman | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Front-end | Version: 1.0-beta (trunk) Severity: major | Resolution: Keywords: works-for-me | --------------------------+------------------------------------------------- Changes (by Potter_System): * keywords: tags => works-for-me Comment: On [1651], everything seems OK with tags. May you check again after updating your SVN copy? -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sun Aug 17 13:17:58 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sun Aug 17 13:18:09 2008 Subject: [Bb-trac] Re: [bbPress] #933: Problem with register form: "1" is show in the first input In-Reply-To: <038.00891ebd7255a4031eee52028535f1b5@lists.bbpress.org> References: <038.00891ebd7255a4031eee52028535f1b5@lists.bbpress.org> Message-ID: <047.dd5c29fb57c2e6f3e5be8078625b090e@lists.bbpress.org> #933: Problem with register form: "1" is show in the first input --------------------------+------------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Registration | Version: 1.0-beta (trunk) Severity: normal | Resolution: Keywords: | --------------------------+------------------------------------------------- Comment (by wiseacre): I confirm it. When I try to register Mr/Miss "1" receive "Name already exists" but it isn't true. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sun Aug 17 13:25:09 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sun Aug 17 13:25:20 2008 Subject: [Bb-trac] Re: [bbPress] #927: logout redirects to blank screen in Opera 9.x In-Reply-To: <035.7b6777e9a77c6160019e903731e98c26@lists.bbpress.org> References: <035.7b6777e9a77c6160019e903731e98c26@lists.bbpress.org> Message-ID: <044.451f8d6e62d2c6e737b8fdbf5234d136@lists.bbpress.org> #927: logout redirects to blank screen in Opera 9.x ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: 0.9.0.2 Severity: normal | Resolution: Keywords: | ----------------------+----------------------------------------------------- Comment (by wiseacre): It's working for me. Opera 9.51 for linux (kubuntu 8.04) and bbpress rev 1651 -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 18 02:36:28 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 18 02:36:40 2008 Subject: [Bb-trac] Re: [bbPress] #932: tag pages broken -- get_tagged_topics() returns empty array In-Reply-To: <039.f7214ea1996264192c9498bb07e44607@lists.bbpress.org> References: <039.f7214ea1996264192c9498bb07e44607@lists.bbpress.org> Message-ID: <048.23e54384e681f8859f10f93174a9cf3e@lists.bbpress.org> #932: tag pages broken -- get_tagged_topics() returns empty array --------------------------+------------------------------------------------- Reporter: zappoman | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Front-end | Version: 1.0-beta (trunk) Severity: major | Resolution: Keywords: works-for-me | --------------------------+------------------------------------------------- Comment (by zappoman): This is failing on the 1651 changeset for me. (I originally reported this against 1651). -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 18 07:13:50 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 18 07:14:02 2008 Subject: [Bb-trac] Re: [bbPress] #932: tag pages broken -- get_tagged_topics() returns empty array In-Reply-To: <039.f7214ea1996264192c9498bb07e44607@lists.bbpress.org> References: <039.f7214ea1996264192c9498bb07e44607@lists.bbpress.org> Message-ID: <048.bd686fbe59613a7c3449a4e784b000ec@lists.bbpress.org> #932: tag pages broken -- get_tagged_topics() returns empty array --------------------------+------------------------------------------------- Reporter: zappoman | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Front-end | Version: 1.0-beta (trunk) Severity: major | Resolution: Keywords: works-for-me | --------------------------+------------------------------------------------- Comment (by zappoman): I think this problem is related to the get_objects_in_term() function from class-bb-taxonomy.php. Namely, the code on line 59 reads... {{{ $sql = "SELECT tr.object_id FROM {$this->db->term_relationships} AS tr INNER JOIN {$this->db->term_taxonomy} AS tt ON tr.term_taxonomy_id = tt.term_taxonomy_id WHERE tt.taxonomy IN ($taxonomies) AND tt.term_id IN ($terms)"; }}} But I thinkthat actually tt.term_id should be tt.term_taxonomy_id. So, when I apply the following diff... it seems to work. {{{ Index: bb-includes/class-bb-taxonomy.php =================================================================== --- bb-includes/class-bb-taxonomy.php (revision 1651) +++ bb-includes/class-bb-taxonomy.php (working copy) @@ -56,7 +56,7 @@ $taxonomies = "'" . implode("', '", $taxonomies) . "'"; $terms = "'" . implode("', '", $terms) . "'"; - $sql = "SELECT tr.object_id FROM {$this->db->term_relationships} AS tr INNER JOIN {$this->db->term_taxonomy} AS tt ON tr.term_taxonomy_id = tt.term_taxonomy_id WHERE tt.taxonomy IN ($taxonomies) AND tt.term_id IN ($terms)"; + $sql = "SELECT tr.object_id FROM {$this->db->term_relationships} AS tr INNER JOIN {$this->db->term_taxonomy} AS tt ON tr.term_taxonomy_id = tt.term_taxonomy_id WHERE tt.taxonomy IN ($taxonomies) AND tt.term_taxonomy_id IN ($terms)"; if ( $user_id ) $sql .= " AND tr.user_id = '$user_id'"; $sql .= " ORDER BY tr.object_id $order"; }}} -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 18 07:14:51 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 18 07:15:02 2008 Subject: [Bb-trac] Re: [bbPress] #932: tag pages broken -- get_tagged_topics() returns empty array In-Reply-To: <039.f7214ea1996264192c9498bb07e44607@lists.bbpress.org> References: <039.f7214ea1996264192c9498bb07e44607@lists.bbpress.org> Message-ID: <048.37ea32527fafa5c8707fb4c495eaff77@lists.bbpress.org> #932: tag pages broken -- get_tagged_topics() returns empty array -----------------------------------+---------------------------------------- Reporter: zappoman | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Front-end | Version: 1.0-beta (trunk) Severity: major | Resolution: Keywords: tags upgrade taxonomy | -----------------------------------+---------------------------------------- Changes (by zappoman): * keywords: works-for-me => tags upgrade taxonomy -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 18 17:39:18 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 18 17:39:31 2008 Subject: [Bb-trac] [bbPress] #934: recursive statics not reset in bb_get_forums_hierarchical() when called multiple times on single page Message-ID: <039.9a432475a76436ea6f207ef9d63737d3@lists.bbpress.org> #934: recursive statics not reset in bb_get_forums_hierarchical() when called multiple times on single page -----------------------+---------------------------------------------------- Reporter: zappoman | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Front-end | Version: 1.0-beta (trunk) Severity: normal | Keywords: 0.8.x, 1.0-beta, 1.0-alpha, dropdown -----------------------+---------------------------------------------------- The recursive function bb_get_forums_hierarchical() fails to produce proper results if it is called more than once on a page. An use case example is a home page that shows all forums and includes a post-form at the bottom that includes the bb_new_topic_forum_dropdown() forum drop down list. The bug relates to the fact that the recursion is controlled by the static _leaves variable, which starts out as false on the first call, and then is reset to contain the current leaves of the recursive calls. This is all well and good for the first top level call, but when the first call fully unwinds the recursion, the static variable is left set to an empty array, instead of being set to false... as a result, all subsequent calls will return with an empty array. One fix to this is to implement a top level wrapper, which is called as the public api to bb_get_forums_hierarchical() which resets the control variable to false, and calls the (pseudo) private function. Here is a diff which fixes this problem. {{{ Index: bb-includes/functions.php =================================================================== --- bb-includes/functions.php (revision 1651) +++ bb-includes/functions.php (working copy) @@ -122,9 +122,15 @@ } /* Forums */ +function bb_get_forums_hierarchical( $root = 0, $depth = 0, $leaves = false, $_recursed = false ) { + global $_leaves; + $_leaves = false; + return _bb_get_forums_hierarchical($root,$depth,$leaves,$_recursed); +} -function bb_get_forums_hierarchical( $root = 0, $depth = 0, $leaves = false, $_recursed = false ) { - static $_leaves = false; +function _bb_get_forums_hierarchical( $root = 0, $depth = 0, $leaves = false, $_recursed = false ) { + global $_leaves; + $root = (int) $root; if ( false === $_leaves ) @@ -141,7 +147,7 @@ if ( $root == $leaf->forum_parent ) { $new_root = (int) $leaf->forum_id; unset($_leaves[$l]); - $branch[$new_root] = 1 == $depth ? true : bb_get_forums_hierarchical( $new_root, $depth - 1, false, true ); + $branch[$new_root] = 1 == $depth ? true : _bb_get_forums_hierarchical( $new_root, $depth - 1, false, true ); reset($_leaves); } } }}} -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 18 20:20:41 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 18 20:20:56 2008 Subject: [Bb-trac] [bbPress] #935: Forum is Category Not Working for Existing Forum Message-ID: <035.2670a7ab851575d7c2c1acd67c6caf23@lists.bbpress.org> #935: Forum is Category Not Working for Existing Forum ----------------------------+----------------------------------------------- Reporter: jenz | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Administration | Version: 1.0-alpha-1 Severity: normal | Keywords: ----------------------------+----------------------------------------------- In Version 1.0-alpha-1 - if you create a forum, click "Add Forum" then go to "Edit" and decide you want the existing forum to be a "category" by checking "Forum is Category" - that option will not stick. The only way to make this functionality work currently is to make a forum a category is during the initial add forum. This behavior can be seen on a clean install of bbPress Version 1.0-alpha-1 -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 18 23:15:42 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 18 23:15:54 2008 Subject: [Bb-trac] [bbPress] #936: Priviliges ignored Message-ID: <039.074494600c2b9457f70d1df9049364fe@lists.bbpress.org> #936: Priviliges ignored -------------------------+-------------------------------------------------- Reporter: holloway | Owner: Type: defect | Status: new Priority: high | Milestone: 1.0-beta & XML-RPC Component: integration | Version: 1.0-alpha-1 Severity: major | Keywords: -------------------------+-------------------------------------------------- When the necessary wordpress line is added to bb-config, an error occurs where a user appears to have all their rights but any attempts to make use of these (entering admin panel, clicking submit on a new post, pressing edit in profile etc) has no effect and just redirects user to the board index. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 19 04:33:31 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 19 04:33:42 2008 Subject: [Bb-trac] [bbPress] #937: 100k PHPmailer should be a plugin and not in the core Message-ID: <035.1ddcea80a25d10cef18f49804aef2328@lists.bbpress.org> #937: 100k PHPmailer should be a plugin and not in the core ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: high | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: major | Keywords: ----------------------+----------------------------------------------------- I could not disagree more with putting big, bulky and slow PHPmailer in the core when 99% of installs will not need it's functionality. The email functions are in `pluggable.php` for a reason, any replacement should be a plugin. If you insist on including it, it should at least be in bb-plugins with the bozo and akismet plugins so I can disable it. What if people want to use Swift Mailer instead? Please roll back the old mailer in pluggable so it keeps the core size small and light. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 19 09:37:49 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 19 09:38:14 2008 Subject: [Bb-trac] Re: [bbPress] #937: 100k PHPmailer should be a plugin and not in the core In-Reply-To: <035.1ddcea80a25d10cef18f49804aef2328@lists.bbpress.org> References: <035.1ddcea80a25d10cef18f49804aef2328@lists.bbpress.org> Message-ID: <044.8c38831d4db06e91542d130a835f8fea@lists.bbpress.org> #937: 100k PHPmailer should be a plugin and not in the core ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: high | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: major | Resolution: Keywords: | ----------------------+----------------------------------------------------- Comment (by csseur3): i'm agree with you _ck_ :p -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 19 11:38:23 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 19 11:38:35 2008 Subject: [Bb-trac] Re: [bbPress] #937: 100k PHPmailer should be a plugin and not in the core In-Reply-To: <035.1ddcea80a25d10cef18f49804aef2328@lists.bbpress.org> References: <035.1ddcea80a25d10cef18f49804aef2328@lists.bbpress.org> Message-ID: <044.702391fc5ff591bbf31afec798fe2a9f@lists.bbpress.org> #937: 100k PHPmailer should be a plugin and not in the core ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: high | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: major | Resolution: Keywords: | ----------------------+----------------------------------------------------- Comment (by fel64): Shouldn't email functions be outsourced into backpress? -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 19 16:17:06 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 19 16:17:18 2008 Subject: [Bb-trac] [bbPress] #938: Allow accents in nicks Message-ID: <038.5083899baa6ff6847720d696e0029cfb@lists.bbpress.org> #938: Allow accents in nicks --------------------------+------------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Registration | Version: 1.0-beta (trunk) Severity: normal | Keywords: --------------------------+------------------------------------------------- I think this is a great frustration for non-English-speaking people be offered only nicks without accents :) -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 20 00:01:42 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 20 00:01:55 2008 Subject: [Bb-trac] Re: [bbPress] #938: Allow accents in nicks In-Reply-To: <038.5083899baa6ff6847720d696e0029cfb@lists.bbpress.org> References: <038.5083899baa6ff6847720d696e0029cfb@lists.bbpress.org> Message-ID: <047.4c1dba7db4b99726645b4314b84ecc9b@lists.bbpress.org> #938: Allow accents in nicks --------------------------+------------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: Registration | Version: 1.0-beta (trunk) Severity: normal | Resolution: duplicate Keywords: | --------------------------+------------------------------------------------- Changes (by sambauers): * status: new => closed * resolution: => duplicate * milestone: 1.0-beta & XML-RPC => Comment: Duplicate of #452, which is wontfix. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 20 00:09:51 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 20 00:10:01 2008 Subject: [Bb-trac] Re: [bbPress] #937: 100k PHPmailer should be a plugin and not in the core In-Reply-To: <035.1ddcea80a25d10cef18f49804aef2328@lists.bbpress.org> References: <035.1ddcea80a25d10cef18f49804aef2328@lists.bbpress.org> Message-ID: <044.506a8ed25e628242f28be306cbcf01dc@lists.bbpress.org> #937: 100k PHPmailer should be a plugin and not in the core ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: high | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: 1.0-alpha-1 Severity: major | Resolution: Keywords: | ----------------------+----------------------------------------------------- Changes (by sambauers): * version: => 1.0-alpha-1 Comment: PHP Mailer is in BackPress. It is only loaded when an email is sent, so it doesn't really increase the footprint for the vast majority of page loads. To replace it with Swift Mailer you can re-define bb_mail() in a plugin. That is the only place it is included. The version we have added to BackPress is really well tested as it has come from WordPress, and we have had lots of issues with the previous implementation. If/when BackPress is utilised in WordPress, this library would be included at that time anyway. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 20 00:44:12 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 20 00:44:24 2008 Subject: [Bb-trac] Re: [bbPress] #937: 100k PHPmailer should be a plugin and not in the core In-Reply-To: <035.1ddcea80a25d10cef18f49804aef2328@lists.bbpress.org> References: <035.1ddcea80a25d10cef18f49804aef2328@lists.bbpress.org> Message-ID: <044.f275d47f9e6fb95c650075ed57e7953f@lists.bbpress.org> #937: 100k PHPmailer should be a plugin and not in the core ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: low | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: 1.0-alpha-1 Severity: minor | Resolution: Keywords: | ----------------------+----------------------------------------------------- Changes (by sambauers): * priority: high => low * severity: major => minor -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 20 04:09:45 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 20 04:09:58 2008 Subject: [Bb-trac] [bbPress] #939: there is no attribute "start" error in default template Message-ID: <038.cff77ab5792882297064426c2fa626ef@lists.bbpress.org> #939: there is no attribute "start" error in default template -----------------------+---------------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-beta (trunk) Severity: normal | Keywords: -----------------------+---------------------------------------------------- Hello, with this code: {{{

bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 20 08:15:06 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 20 08:15:23 2008 Subject: [Bb-trac] Re: [bbPress] #937: 100k PHPmailer should be a plugin and not in the core In-Reply-To: <035.1ddcea80a25d10cef18f49804aef2328@lists.bbpress.org> References: <035.1ddcea80a25d10cef18f49804aef2328@lists.bbpress.org> Message-ID: <044.27be98ba6169e081908b2cba97f1300a@lists.bbpress.org> #937: 100k PHPmailer should be a plugin and not in the core ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: low | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: 1.0-alpha-1 Severity: minor | Resolution: Keywords: | ----------------------+----------------------------------------------------- Comment (by _ck_): I still don't understand why it's included by default in BackPress when most users won't be using it. Shouldn't the 1% with hosting issues be the ones required to bulk-up only their install with additional code? What happened to the concept of lightweight? A fully integrated install of bbPress 1.0 with WordPress 2.6(even using the shared BackPress core) plus plugins will be over 1 meg of PHP code per instance - 100k of additional code is significant, especially if on a NFS filesystem that's slow to respond (like Dreamhost). When bbPress is enhanced with plugins to perform typical forum behaviors like sending emails when new users sign up or emails when new posts are made in tracked topics, emails happen much more often than you'd think, especially on a busy site. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 20 09:53:05 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 20 09:53:18 2008 Subject: [Bb-trac] Re: [bbPress] #939: there is no attribute "start" error in default template In-Reply-To: <038.cff77ab5792882297064426c2fa626ef@lists.bbpress.org> References: <038.cff77ab5792882297064426c2fa626ef@lists.bbpress.org> Message-ID: <047.61ac08b97b71546c2be1345b9367d472@lists.bbpress.org> #939: there is no attribute "start" error in default template -----------------------+---------------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-beta (trunk) Severity: normal | Resolution: Keywords: | -----------------------+---------------------------------------------------- Comment (by fel64): It used to be in the HTML specification. It's now deprecated. http://www.w3.org/TR/html401/struct/lists.html#h-10.2 But I think browsers still use it. I haven't got a theme to test on, maybe someone else can confirm? While it works, I like having this in bbpress: it's useful and non-validation in this way is trivial. Otherwise, in a theme with post numbers clearly visible, they'd just run from 1-30 every page. That's nonsensical. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 20 13:39:08 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 20 13:39:22 2008 Subject: [Bb-trac] Re: [bbPress] #939: there is no attribute "start" error in default template In-Reply-To: <038.cff77ab5792882297064426c2fa626ef@lists.bbpress.org> References: <038.cff77ab5792882297064426c2fa626ef@lists.bbpress.org> Message-ID: <047.dbaca48b45b21b875812e1033cc2f3eb@lists.bbpress.org> #939: there is no attribute "start" error in default template -----------------------+---------------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-beta (trunk) Severity: normal | Resolution: Keywords: | -----------------------+---------------------------------------------------- Comment (by wiseacre): Confirm with Kakumei and Kakumei Blue themes -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 20 14:12:49 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 20 14:13:00 2008 Subject: [Bb-trac] [bbPress] #940: post_author_title_link filter fires twice, should be get_post_author_title_link Message-ID: <035.80ad113bece822a6a3938c08092a21c8@lists.bbpress.org> #940: post_author_title_link filter fires twice, should be get_post_author_title_link ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: normal | Keywords: ----------------------+----------------------------------------------------- Around line 1459 you have get_post_author_title_link using the filter action of just "post_author_title_link" (without the get). Since the display non-get function also fires the same filter, it performs the filter twice. Should instead be "get_post_author_title_link". Oh and you broke a few of my plugins just by changing this function name used in the post.php template :-( {{{ function post_author_title_link( $post_id = 0 ) { echo apply_filters( 'post_author_title_link', get_post_author_title_link( $post_id ), get_post_id( $post_id ) ); } function get_post_author_title_link( $post_id = 0 ) { $title = get_post_author_title( $post_id ); if ( false === $title ) $r = __('Unregistered'); // This should never happen else $r = '' . $title . ''; echo apply_filters( 'post_author_title_link', $r, get_post_id( $post_id ) ); } }}} -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Thu Aug 21 21:20:00 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Thu Aug 21 21:20:12 2008 Subject: [Bb-trac] Re: [bbPress] #939: there is no attribute "start" error in default template In-Reply-To: <038.cff77ab5792882297064426c2fa626ef@lists.bbpress.org> References: <038.cff77ab5792882297064426c2fa626ef@lists.bbpress.org> Message-ID: <047.26ea567029b0482814913df1336974ef@lists.bbpress.org> #939: there is no attribute "start" error in default template -----------------------+---------------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-beta (trunk) Severity: normal | Resolution: Keywords: | -----------------------+---------------------------------------------------- Comment (by fel64): It works in FF2 and 3. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Fri Aug 22 22:45:32 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Fri Aug 22 22:45:48 2008 Subject: [Bb-trac] [bbPress] #941: Cookie integration: extra slashes in bb Message-ID: <036.499e3d1d98b232e14774ceed88560148@lists.bbpress.org> #941: Cookie integration: extra slashes in bb -------------------------+-------------------------------------------------- Reporter: fel64 | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: integration | Version: 1.0-beta (trunk) Severity: normal | Keywords: -------------------------+-------------------------------------------------- Running Trunk and 2.6.1; the problem is new since upgrading from 0.9. User tables integrated, auth keys of all kinds are identical. Trying to set it up such that logging into WP logs you into bb and vice versa. * Logging into WP does not log me into bb, but it does log me out of bb. * Logging into bb does not log me into WP, but it does log me out of WP. Each has been repeatable. The only kind of cookies I've seen are wordpress_#some_hash# and wordpress_logged_in_#that_same_hash#. I believe that this may be due to an unknown problem with my setup. bbPress is setup in a subdomain, forums.loinhead.net, while WP is set up on www.loinhead.net. bbPress automatically sets cookies for .loinhead.net. I have changed Wordpress' behaviour to do that by defining COOKIE_DOMAIN in its wp-config. I have found one difference between the cookies set by wordpress and bbpress that is probably a mistake: The WP-set cookie called wordpress_#some_long_hash# is set twice, once for /wordpress`/wp-admin`, and once for `/wordpress/wp-content/plugins`. The bb-set cookie called wordpress_#the_same_long_hash# is set five times, once for `/wordpress/wp-admin/`, and once for `/wordpress/wp- content/plugins/`, and three times for bb-specific folders. I'm suspicious of the extra trailing slash. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Fri Aug 22 23:57:34 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Fri Aug 22 23:57:47 2008 Subject: [Bb-trac] [bbPress] #942: Submit on login form should not have an id of "submit" Message-ID: <036.eea455d62a0a047dc8121a3058f33552@lists.bbpress.org> #942: Submit on login form should not have an id of "submit" -----------------------+---------------------------------------------------- Reporter: fel64 | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Front-end | Version: 1.0-beta (trunk) Severity: minor | Keywords: -----------------------+---------------------------------------------------- Submit on login form should not have an id of "submit", not when there can be many more submit buttons on a page. Let the search button lead by example and change the login form's submit button to have a `class="submit"` not an `id="submit"`. Makes it easier to style them together, too. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sat Aug 23 06:45:46 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sat Aug 23 06:46:15 2008 Subject: [Bb-trac] Re: [bbPress] #942: Submit on login form should not have an id of "submit" In-Reply-To: <036.eea455d62a0a047dc8121a3058f33552@lists.bbpress.org> References: <036.eea455d62a0a047dc8121a3058f33552@lists.bbpress.org> Message-ID: <045.1994483b15c3618d17d6098afb4a4917@lists.bbpress.org> #942: Submit on login form should not have an id of "submit" -----------------------+---------------------------------------------------- Reporter: fel64 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-beta (trunk) Severity: minor | Resolution: Keywords: | -----------------------+---------------------------------------------------- Changes (by wiseacre): * milestone: => 1.0-beta & XML-RPC Comment: It sounds logical. I suggest Milestone 1.0-beta ...? -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sat Aug 23 16:20:09 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sat Aug 23 16:20:22 2008 Subject: [Bb-trac] [bbPress] #943: add ability to filter topic_time()'s output as well as its input time Message-ID: <036.ba5aa8b96d08efaf724d3c83c1898929@lists.bbpress.org> #943: add ability to filter topic_time()'s output as well as its input time -------------------------+-------------------------------------------------- Reporter: fel64 | Owner: Type: enhancement | Status: new Priority: normal | Milestone: Component: Back-end | Version: 1.0-beta (trunk) Severity: normal | Keywords: -------------------------+-------------------------------------------------- The code for `topic_time()`, used in topic listings, is here: {{{ function topic_time( $args = '' ) { $args = _bb_parse_time_function_args( $args ); $time = apply_filters( 'topic_time', get_topic_time( array('format' => 'mysql') + $args), $args ); echo _bb_time_function_return( $time, $args ); } }}} You can see that the filter `topic_time` filters the actual time, which is then passed to `_bb_time_function_return()`, which does a little processing and then passes it to `bb_gmdate_i18n()` which then returns something. A filter is not applied again (as far as I can tell - the time functions are not very easy to read). If someone wishes to change how the time is displayed, they have to change the functions in their template files. In my opinion this would be better done with a plugin; it increases theme maintanability (since less theme files have to be changed, thus more of them can come from the up-to-date kakumei). A plugin could be used or, equally, the change could be made using plugin- like code in the theme's functions.php. It may be a design decision, but I think it's best implemented using code, and for that bbPress needs to filter topic_time()'s output. The filter should also pass the time as an argument. Additional filter names could be `echo_topic_time` and, for `get_topic_time()`, `return_topic_time`. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 25 03:23:16 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 25 03:23:29 2008 Subject: [Bb-trac] [bbPress] #944: Views are broken Message-ID: <039.aff81ce9a772e3b48bc51abd2ce36f9f@lists.bbpress.org> #944: Views are broken -----------------------+---------------------------------------------------- Reporter: wiseacre | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-alpha-1 Severity: normal | Keywords: -----------------------+---------------------------------------------------- "Topics with no replies" and "Topics with no tags" views give the direct contrary of the expected result. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Mon Aug 25 09:46:00 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Mon Aug 25 09:46:31 2008 Subject: [Bb-trac] Re: [bbPress] #944: Views are broken In-Reply-To: <039.aff81ce9a772e3b48bc51abd2ce36f9f@lists.bbpress.org> References: <039.aff81ce9a772e3b48bc51abd2ce36f9f@lists.bbpress.org> Message-ID: <048.b7e8ee882c7e721efb46fc7426171bce@lists.bbpress.org> #944: Views are broken -----------------------+---------------------------------------------------- Reporter: wiseacre | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-alpha-1 Severity: normal | Resolution: Keywords: | -----------------------+---------------------------------------------------- Comment (by fel64): worksforme in trunk -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 15:11:35 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 15:11:52 2008 Subject: [Bb-trac] [bbPress] #945: plugins activate but don't actually run on IIS + PHP 4.3 Message-ID: <035.782efec1bb46d2d3f892a192f21a606f@lists.bbpress.org> #945: plugins activate but don't actually run on IIS + PHP 4.3 ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Back-end | Version: 1.0-alpha-1 Severity: normal | Keywords: ----------------------+----------------------------------------------------- There is some kind of issue with bbPress 1.0 alpha (and perhaps 0.9 too) where plugins will activate but not actually execute on IIS servers running PHP 4.3 WordPress 2.6 runs just fine on the same server with plugins. I have verified the user does NOT have safe mode enabled. Could this be a GLOB issue or has that been resolved? Is there possibly some code in there that relies on a change in PHP after 4.3? -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 15:20:25 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 15:20:37 2008 Subject: [Bb-trac] Re: [bbPress] #945: plugins activate but don't actually run on IIS + PHP 4.3 In-Reply-To: <035.782efec1bb46d2d3f892a192f21a606f@lists.bbpress.org> References: <035.782efec1bb46d2d3f892a192f21a606f@lists.bbpress.org> Message-ID: <044.4d589ad89ea57173cbf86c689446e6dc@lists.bbpress.org> #945: plugins activate but don't actually run on IIS + PHP 4.3 ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Back-end | Version: 1.0-alpha-1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------------------------------------- Comment (by fel64): Have the same issue running xampp on windows, with PHP 5.x. Plugins activate but do not run. Wordpress and wordpress plugins run ok. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 15:22:10 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 15:22:24 2008 Subject: [Bb-trac] [bbPress] #946: forum parent dropdown on forum creation Message-ID: <036.bc44b27cab2bf5072c350604db7c2f45@lists.bbpress.org> #946: forum parent dropdown on forum creation ----------------------------+----------------------------------------------- Reporter: keppy | Owner: Type: enhancement | Status: new Priority: low | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-beta (trunk) Severity: minor | Keywords: parent ----------------------------+----------------------------------------------- It would be useful to have the forum parent dropdown available in the add forum form and not just in the edit forum area. For example, when setting up your a new bbpress install, you are typically creating a lot of forums and sub-forums for whatever type of organizational structure you want. Currently it is sort of a pain to have to add a forum, then immediately edit the forum and apply a parent to it. So it would be useful to apply a parent while adding the new one. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 15:54:12 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 15:54:24 2008 Subject: [Bb-trac] Re: [bbPress] #945: plugins activate but don't actually run on IIS + PHP 4.3 In-Reply-To: <035.782efec1bb46d2d3f892a192f21a606f@lists.bbpress.org> References: <035.782efec1bb46d2d3f892a192f21a606f@lists.bbpress.org> Message-ID: <044.3abd9b2eca0f7a01a0a00dd4203b233d@lists.bbpress.org> #945: plugins activate but don't actually run on IIS + PHP 4.3 ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Back-end | Version: 1.0-alpha-1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------------------------------------- Comment (by _ck_): fel64 thanks for that report - do you get any special warnings if you turn on all error reporting ie. in bb-config.php put error_reporting(E_ALL); -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 16:00:23 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 16:00:34 2008 Subject: [Bb-trac] Re: [bbPress] #945: plugins activate but don't actually run on IIS + PHP 4.3 In-Reply-To: <035.782efec1bb46d2d3f892a192f21a606f@lists.bbpress.org> References: <035.782efec1bb46d2d3f892a192f21a606f@lists.bbpress.org> Message-ID: <044.6c89dcfffd1aa1a662271bdd8b3e4247@lists.bbpress.org> #945: plugins activate but don't actually run on IIS + PHP 4.3 ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Back-end | Version: 1.0-alpha-1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------------------------------------- Comment (by _ck_): Ah I bet this has to do with Windows and it's silly paths that use "\" instead of "/" and how dirname is used to try to calculate the web path based on the physical file path. I had the same problem in a number of my plugins and had to come up with this contortion to make it work: {{{ $web_path_to_plugin=bb_get_option('uri').trim(str_replace(array(trim(BBPATH,"/\\"),"\\"),array("","/"),dirname(__FILE__)),' /\\').'/'; }}} -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 16:40:05 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 16:40:21 2008 Subject: [Bb-trac] Re: [bbPress] #945: plugins activate but don't actually run on IIS + PHP 4.3 In-Reply-To: <035.782efec1bb46d2d3f892a192f21a606f@lists.bbpress.org> References: <035.782efec1bb46d2d3f892a192f21a606f@lists.bbpress.org> Message-ID: <044.9609073c38e9aea59d4532f729658832@lists.bbpress.org> #945: plugins activate but don't actually run on IIS + PHP 4.3 ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Back-end | Version: 1.0-alpha-1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------------------------------------- Comment (by fel64): No, I don't get anything from E_ALL. The windows problem existed in the .8 days I think for themes, it seems similar but I'd be surprised if it's the same problem again. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 20:44:42 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 20:44:53 2008 Subject: [Bb-trac] Re: [bbPress] #931: Call-time pass-by-reference has been deprecated - argument passed by value; -- in backpress_convert_object() In-Reply-To: <039.763548eadb57781eb67f48c1bc10f20e@lists.bbpress.org> References: <039.763548eadb57781eb67f48c1bc10f20e@lists.bbpress.org> Message-ID: <048.d7a46654cb960273cd1946286b5f787d@lists.bbpress.org> #931: Call-time pass-by-reference has been deprecated - argument passed by value; -- in backpress_convert_object() ----------------------------+----------------------------------------------- Reporter: zappoman | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: Administration | Version: 1.0-beta (trunk) Severity: normal | Resolution: duplicate Keywords: | ----------------------------+----------------------------------------------- Comment (by mdawaffe): Fixed in [BP118] -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 20:45:58 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 20:46:10 2008 Subject: [Bb-trac] Re: [bbPress] #929: Call-time pass-by-reference has been deprecated; [functions.core.php] In-Reply-To: <043.d6ef606a2332b7387271db85240245a0@lists.bbpress.org> References: <043.d6ef606a2332b7387271db85240245a0@lists.bbpress.org> Message-ID: <052.b7633fd956c3f60909c7989b3033cfb2@lists.bbpress.org> #929: Call-time pass-by-reference has been deprecated; [functions.core.php] --------------------------------------------------+------------------------- Reporter: joelteixeira | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: Installation/Upgrade | Version: 1.0-alpha-1 Severity: normal | Resolution: fixed Keywords: install, error, call-time, dreamhost | --------------------------------------------------+------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => fixed Comment: Fixed in [BP118] -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 20:57:40 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 20:58:22 2008 Subject: [Bb-trac] Re: [bbPress] #935: Forum is Category Not Working for Existing Forum In-Reply-To: <035.2670a7ab851575d7c2c1acd67c6caf23@lists.bbpress.org> References: <035.2670a7ab851575d7c2c1acd67c6caf23@lists.bbpress.org> Message-ID: <044.9c97fb09aac4cf1256f913570f5cb8c7@lists.bbpress.org> #935: Forum is Category Not Working for Existing Forum ----------------------------+----------------------------------------------- Reporter: jenz | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: Administration | Version: 1.0-alpha-1 Severity: normal | Resolution: fixed Keywords: | ----------------------------+----------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => fixed Comment: Fixed in [1645] -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 21:21:12 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 21:21:27 2008 Subject: [Bb-trac] Re: [bbPress] #937: 100k PHPmailer should be a plugin and not in the core In-Reply-To: <035.1ddcea80a25d10cef18f49804aef2328@lists.bbpress.org> References: <035.1ddcea80a25d10cef18f49804aef2328@lists.bbpress.org> Message-ID: <044.4812610464737d644206245e4eaf229e@lists.bbpress.org> #937: 100k PHPmailer should be a plugin and not in the core ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: closed Priority: low | Milestone: Component: Back-end | Version: 1.0-alpha-1 Severity: minor | Resolution: wontfix Keywords: | ----------------------+----------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => wontfix * milestone: 1.0-beta & XML-RPC => Comment: I agree that PHP Mailer is not perfect, but PHP Mailer is proven to be a better solution than bbPress' old mail() solution. WordPress made a similar transition (also not without controversy). As an anecdote, I recently used PHP Mailer's SMTP wrapper to send hundreds of thousands of emails over a short period of time and have since improved my code (not PHP Mailer's) to speed up that process by a multiplicative factor. PHP Mailer is never loaded unless you're actually sending an email. If you plug bb_mail() as a Swift Mailer wrapper or a mail() wrapper, PHPMailer will never be loaded. Including this "100k of additional code" in the distribution does not impact page load times, memory usage, or any other efficiency measure: the file is almost never loaded. There may be 1M of PHP files per install, but not all of that is loaded for any given page load. We could package bbPress with a 30M how-to video and similarly not effect your site's performance. Also, you don't know that you're one of the "1% [of people] with hosting issues" until it's too late: your users can't login because they never got an email. If bbPress is plugged or enhanced to send more emails, and someone demonstrates that PHP Mailer truly is slowing things down, and that an alternative exists with the needed features and cross-compatibility, we can decide to use something else. Until then, you can always plug bb_mail() to use something that better suits your needs. Marking this as wontfix for now. Let's address this again when we get real world data. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 21:29:26 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 21:29:38 2008 Subject: [Bb-trac] Re: [bbPress] #939: there is no attribute "start" error in default template In-Reply-To: <038.cff77ab5792882297064426c2fa626ef@lists.bbpress.org> References: <038.cff77ab5792882297064426c2fa626ef@lists.bbpress.org> Message-ID: <047.6587d8804fb7aa75ba774d5d195f46f3@lists.bbpress.org> #939: there is no attribute "start" error in default template -----------------------+---------------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: lowest | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-beta (trunk) Severity: normal | Resolution: Keywords: | -----------------------+---------------------------------------------------- Changes (by mdawaffe): * priority: normal => lowest Comment: The alternative is to get clever with CSS2 counters: http://www.w3.org/TR /REC-CSS2/generate.html#counters Feel free to submit a patch. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 21:40:32 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 21:40:48 2008 Subject: [Bb-trac] Re: [bbPress] #944: Views are broken In-Reply-To: <039.aff81ce9a772e3b48bc51abd2ce36f9f@lists.bbpress.org> References: <039.aff81ce9a772e3b48bc51abd2ce36f9f@lists.bbpress.org> Message-ID: <048.7143acfec94cc9b7642d5d1c0d6df2e1@lists.bbpress.org> #944: Views are broken -----------------------+---------------------------------------------------- Reporter: wiseacre | Owner: Type: defect | Status: closed Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-alpha-1 Severity: normal | Resolution: worksforme Keywords: | -----------------------+---------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => worksforme Comment: Works for me too. Do you have any plugins installed? -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 21:46:17 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 21:46:30 2008 Subject: [Bb-trac] Re: [bbPress] #944: Views are broken In-Reply-To: <039.aff81ce9a772e3b48bc51abd2ce36f9f@lists.bbpress.org> References: <039.aff81ce9a772e3b48bc51abd2ce36f9f@lists.bbpress.org> Message-ID: <048.1f700e703329fe9c0f7df80511fb67ea@lists.bbpress.org> #944: Views are broken -----------------------+---------------------------------------------------- Reporter: wiseacre | Owner: Type: defect | Status: closed Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-alpha-1 Severity: normal | Resolution: worksforme Keywords: | -----------------------+---------------------------------------------------- Comment (by wiseacre): Standard only - Akismet and "Bozo users". But I'm testing in alpha 1 (it's rev 1636) -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 21:35:26 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 22:11:14 2008 Subject: [Bb-trac] Re: [bbPress] #942: Submit on login form should not have an id of "submit" In-Reply-To: <036.eea455d62a0a047dc8121a3058f33552@lists.bbpress.org> References: <036.eea455d62a0a047dc8121a3058f33552@lists.bbpress.org> Message-ID: <045.7e58b290b41cce766056f9e7c36abbdc@lists.bbpress.org> #942: Submit on login form should not have an id of "submit" -----------------------+---------------------------------------------------- Reporter: fel64 | Owner: Type: defect | Status: closed Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-beta (trunk) Severity: minor | Resolution: fixed Keywords: | -----------------------+---------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => fixed Comment: Fixed in [1662] -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 22:18:31 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 22:18:45 2008 Subject: [Bb-trac] Re: [bbPress] #946: forum parent dropdown on forum creation In-Reply-To: <036.bc44b27cab2bf5072c350604db7c2f45@lists.bbpress.org> References: <036.bc44b27cab2bf5072c350604db7c2f45@lists.bbpress.org> Message-ID: <045.ce0afac31a09ad96a4a57eb898cb1284@lists.bbpress.org> #946: forum parent dropdown on forum creation ----------------------------+----------------------------------------------- Reporter: keppy | Owner: mdawaffe Type: enhancement | Status: assigned Priority: low | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-beta (trunk) Severity: minor | Resolution: Keywords: parent | ----------------------------+----------------------------------------------- Changes (by mdawaffe): * owner: => mdawaffe * status: new => assigned -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 23:00:08 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 23:00:25 2008 Subject: [Bb-trac] Re: [bbPress] #945: plugins activate but don't actually run on IIS + PHP 4.3 In-Reply-To: <035.782efec1bb46d2d3f892a192f21a606f@lists.bbpress.org> References: <035.782efec1bb46d2d3f892a192f21a606f@lists.bbpress.org> Message-ID: <044.61bc24d8cd9695fac3a35a0231e1c3c2@lists.bbpress.org> #945: plugins activate but don't actually run on IIS + PHP 4.3 ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Back-end | Version: 1.0-alpha-1 Severity: normal | Resolution: Keywords: | ----------------------+----------------------------------------------------- Comment (by mdawaffe): [1659] Try it now. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 23:03:20 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 23:05:18 2008 Subject: [Bb-trac] Re: [bbPress] #939: there is no attribute "start" error in default template In-Reply-To: <038.cff77ab5792882297064426c2fa626ef@lists.bbpress.org> References: <038.cff77ab5792882297064426c2fa626ef@lists.bbpress.org> Message-ID: <047.521b4e9496b9fd1766632c00adf68341@lists.bbpress.org> #939: there is no attribute "start" error in default template -----------------------+---------------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: new Priority: lowest | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-beta (trunk) Severity: normal | Resolution: Keywords: | -----------------------+---------------------------------------------------- Comment (by mdawaffe): Actually, kakumei does not display any numbers at all anymore, so we can probably get rid of it in the default template and let theme authors do their own thing. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 23:05:56 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 23:06:07 2008 Subject: [Bb-trac] Re: [bbPress] #939: there is no attribute "start" error in default template In-Reply-To: <038.cff77ab5792882297064426c2fa626ef@lists.bbpress.org> References: <038.cff77ab5792882297064426c2fa626ef@lists.bbpress.org> Message-ID: <047.2f934588a54801686423bdbf36b981da@lists.bbpress.org> #939: there is no attribute "start" error in default template -----------------------+---------------------------------------------------- Reporter: csseur3 | Owner: Type: defect | Status: closed Priority: lowest | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 1.0-beta (trunk) Severity: normal | Resolution: fixed Keywords: | -----------------------+---------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => fixed Comment: [1666] -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Tue Aug 26 23:13:45 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Tue Aug 26 23:13:57 2008 Subject: [Bb-trac] Re: [bbPress] #903: using duplicate email fails but gives no message on registration In-Reply-To: <035.1232239e9d5ffa11d3cde54aa24e3def@lists.bbpress.org> References: <035.1232239e9d5ffa11d3cde54aa24e3def@lists.bbpress.org> Message-ID: <044.67201a16cb67bfd77a091f99b13b165e@lists.bbpress.org> #903: using duplicate email fails but gives no message on registration --------------------------+------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: closed Priority: low | Milestone: 1.0-beta & XML-RPC Component: Registration | Version: 1.0-beta (trunk) Severity: minor | Resolution: fixed Keywords: | --------------------------+------------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => fixed Comment: Related: [BP105] So an error message is now passed back to the user, but that means that we leak information on what emails are already in the system. Is that bad? -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 27 00:09:58 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 27 00:13:22 2008 Subject: [Bb-trac] [bbPress] #947: Remove header login form from login.php and register.php templates Message-ID: <039.4e3ef02b3ccea53d8696179b81ec1c52@lists.bbpress.org> #947: Remove header login form from login.php and register.php templates ----------------------------+----------------------------------------------- Reporter: mdawaffe | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-alpha-1 Severity: major | Keywords: accessibility ----------------------------+----------------------------------------------- Having the mini login form in the header of the login template poses an accessibility issue. 1. A user using a screen reader goes to the front page. 2. User tries to log in, but enters an incorrect password in the mini login form in the header. 3. The user is redirected to the main login page. 4. The user tabs through the page to see where he/she is and first encounters the mini login form. Note that the mini login form does not show any errors, just blank fields. To this user using a screen reader, at first glance there is no information about why the login procedure failed. Removing the mini login form from these pages ensures that the user tabs first to the main login form complete with error messages. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 27 03:38:11 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 27 03:38:25 2008 Subject: [Bb-trac] [bbPress] #948: Accessibility improvements for error messages in forms Message-ID: <039.abfabfd4acf06dd2c091b93b338ebb3d@lists.bbpress.org> #948: Accessibility improvements for error messages in forms ----------------------------+----------------------------------------------- Reporter: mdawaffe | Owner: Type: enhancement | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-beta (trunk) Severity: normal | Keywords: accessibility ----------------------------+----------------------------------------------- The way we output error messages in forms can be improved to offer greater accessibility. Right now, error messages are printed out below the form input. When using a screen reader, you don't hear the error until after the input label (the row header) and the input. Attached outputs the error as part of the label (the row header) so that a screen reader will speak the error message along with the label and header before reading the input form. This gives the user more context by strengthening the association between the error message and the relevant form field. The attached patch uses CSS to put the error in a reasonable place on the screen. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 27 03:42:33 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 27 03:48:31 2008 Subject: [Bb-trac] [bbPress] #949: Nonsemantic markup in required form fields Message-ID: <039.e0d15a5d78d2173542531506ca982a26@lists.bbpress.org> #949: Nonsemantic markup in required form fields ----------------------------+----------------------------------------------- Reporter: mdawaffe | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 1.0-beta (trunk) Severity: normal | Keywords: semantic ----------------------------+----------------------------------------------- We currently output {{{^*}}} for required form inputs. I'm unclear if this is decent semantic markup, and, when it is outputted by template functions, is not very nice to theme authors. Attached replaces the markup with generated content from CSS. I'm not that worried about it not working in IE. Theme authors can use the CSS classes to change background colors or whatever if they're interested. Thoughts? -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Wed Aug 27 20:56:40 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Wed Aug 27 20:57:03 2008 Subject: [Bb-trac] [bbPress] #950: Move Roles out of user_meta table Message-ID: <039.0b03d4184658ad41bfca79e0bb64c3da@lists.bbpress.org> #950: Move Roles out of user_meta table ----------------------------+----------------------------------------------- Reporter: mdawaffe | Owner: Type: enhancement | Status: new Priority: normal | Milestone: 1.0 Component: Administration | Version: 1.0-beta (trunk) Severity: normal | Keywords: ----------------------------+----------------------------------------------- On very large sites, the usermeta table can only be queried by user_id or user_id, meta_key. Querying by meta_value does not scale. There are a few places where we query the usermeta table looking for users who are keymasters or moderators. These queries fail to complete on large sites. Attached implements #WP5540 for bbPress/BackPress. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Fri Aug 29 14:03:11 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Fri Aug 29 14:03:23 2008 Subject: [Bb-trac] [bbPress] #951: Incorrect link color for "recount" after deleting a forum Message-ID: <041.25ee44b3723f34134d7390e1cc303d09@lists.bbpress.org> #951: Incorrect link color for "recount" after deleting a forum ----------------------------+----------------------------------------------- Reporter: chrishajer | Owner: Type: enhancement | Status: new Priority: lowest | Milestone: Component: Administration | Version: 1.0-alpha-1 Severity: minor | Keywords: css, href, link ----------------------------+----------------------------------------------- After deleting a forum, there is this message: Forum deleted. You should have bbPress recount your site information. "recount your site information" is linked text but the link is the browser default blue rather than the admin styled links in green. Screenshot attached showing the blue link text. -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sat Aug 30 17:11:34 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sat Aug 30 17:11:50 2008 Subject: [Bb-trac] [bbPress] #952: SQL error when deleting user "Unknown column 'user_id' in 'where clause'" Message-ID: <041.09e1fb237a36c962cba843428d3cd39b@lists.bbpress.org> #952: SQL error when deleting user "Unknown column 'user_id' in 'where clause'" ----------------------------+----------------------------------------------- Reporter: chrishajer | Owner: Type: defect | Status: new Priority: low | Milestone: Component: Administration | Version: 1.0-alpha-1 Severity: minor | Keywords: sql, delete, user ----------------------------+----------------------------------------------- When deleting a user, the following error is shown: '''DB Error in WP_Users::delete_user:''' Unknown column 'user_id' in 'where clause' DELETE FROM bbpress_users WHERE user_id = 4 (There is no "user_id" field in the bbpress_users table - it's called "ID") The user existed and was displayed in the User section of the admin panel. And when I refreshed the admin panel > Users, the user was gone. It appeared that the deletion actually occurred, but there was an error displayed indicating that it didn't. I was able to recreate this with 2 different users and took a 20 second video of the 2nd time here showing the error and the fact that the user is actually gone afterward: http://www.chrishajer.com/bbpress/delete-user/ -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sat Aug 30 19:00:36 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sat Aug 30 19:14:10 2008 Subject: [Bb-trac] Re: [bbPress] #952: SQL error when deleting user "Unknown column 'user_id' in 'where clause'" In-Reply-To: <041.09e1fb237a36c962cba843428d3cd39b@lists.bbpress.org> References: <041.09e1fb237a36c962cba843428d3cd39b@lists.bbpress.org> Message-ID: <050.5e8e22b1f7c76a5b61bee452f01de3c2@lists.bbpress.org> #952: SQL error when deleting user "Unknown column 'user_id' in 'where clause'" -------------------------------+-------------------------------------------- Reporter: chrishajer | Owner: Type: defect | Status: closed Priority: low | Milestone: Component: Administration | Version: 1.0-alpha-1 Severity: minor | Resolution: fixed Keywords: sql, delete, user | -------------------------------+-------------------------------------------- Changes (by mdawaffe): * status: new => closed * resolution: => fixed Comment: Fixed in [BP122] Thanks! -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sun Aug 31 09:22:15 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sun Aug 31 09:22:27 2008 Subject: [Bb-trac] Re: [bbPress] #677: Search Page styling In-Reply-To: <039.b167ecc8f7f1e0dae85887664e0c84fa@lists.bbpress.org> References: <039.b167ecc8f7f1e0dae85887664e0c84fa@lists.bbpress.org> Message-ID: <048.3489db0fede4305ad960a5ca51fef2d3@lists.bbpress.org> #677: Search Page styling -------------------------+-------------------------------------------------- Reporter: mdawaffe | Owner: Type: enhancement | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Front-end | Version: 0.8.3 Severity: normal | Resolution: Keywords: has-patch | -------------------------+-------------------------------------------------- Changes (by _ck_): * type: defect => enhancement -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sun Aug 31 09:22:22 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sun Aug 31 09:22:34 2008 Subject: [Bb-trac] Re: [bbPress] #661: XML-RPC and receive pingbacks In-Reply-To: <039.f06b6227c9c6e117a7982cbddcaa9227@lists.bbpress.org> References: <039.f06b6227c9c6e117a7982cbddcaa9227@lists.bbpress.org> Message-ID: <048.48b24ac80158c93885dcd5c63224b091@lists.bbpress.org> #661: XML-RPC and receive pingbacks -----------------------------+---------------------------------------------- Reporter: mdawaffe | Owner: Type: enhancement | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Administration | Version: 0.8.2 Severity: normal | Resolution: Keywords: pingback xmlrpc | -----------------------------+---------------------------------------------- Changes (by _ck_): * type: defect => enhancement -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sun Aug 31 09:22:39 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sun Aug 31 09:22:53 2008 Subject: [Bb-trac] Re: [bbPress] #836: PHPDoc effort for core files In-Reply-To: <037.a2ae8564c921fab58a40a5073062723b@lists.bbpress.org> References: <037.a2ae8564c921fab58a40a5073062723b@lists.bbpress.org> Message-ID: <046.567395e7e464348c7618e854489af1f6@lists.bbpress.org> #836: PHPDoc effort for core files -------------------------+-------------------------------------------------- Reporter: rmccue | Owner: rmccue Type: enhancement | Status: new Priority: low | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: 1.0-beta (trunk) Severity: normal | Resolution: Keywords: phpdoc | -------------------------+-------------------------------------------------- Changes (by _ck_): * type: defect => enhancement -- Ticket URL: bbPress Innovative forum development From bb-trac at lists.bbpress.org Sun Aug 31 15:57:52 2008 From: bb-trac at lists.bbpress.org (bbPress) Date: Sun Aug 31 15:58:07 2008 Subject: [Bb-trac] [bbPress] #953: mysql db upgrade can't set column default to '' on type text Message-ID: <035.cd00c526afdbae99485896b69bf109e7@lists.bbpress.org> #953: mysql db upgrade can't set column default to '' on type text ----------------------+----------------------------------------------------- Reporter: _ck_ | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.0-beta & XML-RPC Component: Back-end | Version: Severity: normal | Keywords: ----------------------+----------------------------------------------------- during trunk update: {{{ >>>>>> ALTER TABLE `bb_forums` ALTER COLUMN `forum_desc` SET DEFAULT ''; >>>>>> BLOB/TEXT column 'forum_desc' can't have a default value SQL ERROR! >>>>>> ALTER TABLE `bb_posts` ALTER COLUMN `post_text` SET DEFAULT ''; >>>>>> BLOB/TEXT column 'post_text' can't have a default value }}} -- Ticket URL: bbPress Innovative forum development